Summary: | Services Directory and itemrecorddisplay.pl File Missing After Install | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P1 - high | CC: | chris, julian.maurice, koha.sekjal, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 7178 | ||
Attachments: |
Bug 8135 : Fix installer to copy services/ dir
[SIGNED-OFF] Bug 8135 : Fix installer to copy services/ dir |
Description
David Cook
2012-05-22 07:14:58 UTC
You mean after you ran perl Makefile.PL make make install The files weren't copied over? I can confirm they are in the tarball too 19:18 ~/src$ wget http://download.koha-community.org/koha-3.8.1.tar.gz 19:20 ~/src$ tar xzf koha-3.8.1.tar.gz 19:20 ~/src$ ls koha-3.8.1/services/ itemrecorddisplay.pl Will test the installer now Yep you are right './reviews' => 'INTRANET_CGI_DIR', './serials' => 'INTRANET_CGI_DIR', './skel' => 'NONE', The Makefile.PL is not set up to copy that dir over. Bug 7178 commit eefc774e274ce8167f1063be5f9204a0d5cf5650 introduced this file, but the Makefile.PL was never updated to copy this file. It was released in 3.8.0 and the fixed has missed 3.8.1 Ill attach a patch if you could sign off David we can hopefully get it into 3.8.2 Created attachment 9688 [details] [review] Bug 8135 : Fix installer to copy services/ dir Created attachment 9689 [details] [review] [SIGNED-OFF] Bug 8135 : Fix installer to copy services/ dir Tried to `perl Makefile.PL; make; make install` using "single" install mode. On master, services/itemrecorddisplay.pl is not copied. With the patch it is copied. Signed off. Consequence of bug 7178, adds new directory to Makefile.PL. Marking Passed QA Will be in 3.8.2 |