We cloned the Koha git on 5 May 2012, and noticed today (22 May 2012) that while the cloned repository contains the Services directory and itemrecorddisplay.pl file, the installed folders are missing the above-mentioned directory and file.
We just copied the files across directly, but it looks like there might be an issue with the installer. Has anyone else had this issue?
The absence of this script means that you can't place orders in the Acquisitions module when you have AcqCreateItem set to "placing an order", since you can't add any items and item quantity defaults to '0', which doesn't pass validation tests on submit.
You mean after you ran perl Makefile.PL
The files weren't copied over?
I can confirm they are in the tarball too
19:18 ~/src$ wget http://download.koha-community.org/koha-3.8.1.tar.gz
19:20 ~/src$ tar xzf koha-3.8.1.tar.gz
19:20 ~/src$ ls koha-3.8.1/services/
Will test the installer now
Yep you are right
'./reviews' => 'INTRANET_CGI_DIR',
'./serials' => 'INTRANET_CGI_DIR',
'./skel' => 'NONE',
The Makefile.PL is not set up to copy that dir over.
Bug 7178 commit eefc774e274ce8167f1063be5f9204a0d5cf5650 introduced this file, but the Makefile.PL was never updated to copy this file.
It was released in 3.8.0 and the fixed has missed 3.8.1
Ill attach a patch if you could sign off David we can hopefully get it into 3.8.2
Created attachment 9688 [details] [review]
Bug 8135 : Fix installer to copy services/ dir
Created attachment 9689 [details] [review]
[SIGNED-OFF] Bug 8135 : Fix installer to copy services/ dir
Tried to `perl Makefile.PL; make; make install` using "single" install mode.
On master, services/itemrecorddisplay.pl is not copied.
With the patch it is copied.
Consequence of bug 7178, adds new directory to Makefile.PL. Marking Passed QA
Will be in 3.8.2