Bug 8172

Summary:	Missing dereference marker for buildQuery parameter in addbooks.pl
Product:	Koha	Reporter:	Mark Tompsett <mtompset>
Component:	Searching	Assignee:	Galen Charlton <gmcharlt>
Status:	CLOSED FIXED	QA Contact:	Jonathan Druart <jonathan.druart>
Severity:	major
Priority:	P5 - low	CC:	chris, jonathan.druart, paul.poulain
Version:	3.8
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Added a missing dereference marker for an array parameter. Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery. Bug 8172: Followup: Removes useless empty params Bug 8172: Followup: Removes useless empty params

Description Mark Tompsett 2012-05-31 18:36:40 UTC

my ( $builterror,$builtquery,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$stopwords_removed,$query_type) = buildQuery(\@operators,\@operands,\@indexes,@limits,\@sort_by,undef,undef);

Which is roughly line 75 of addbooks.pl likely should have a \ on the @limits.
Because C4::Search.pm around line 1044 shows the parameters being treated the same.

I was hoping this would solve my Lingua::Stem::Snowball error, but I will have to continue to hunt deeper.

Comment 1 Mark Tompsett 2012-06-12 09:58:49 UTC

I was looking originally at 3.6.3. I downloaded 3.8.1 and confirmed this bug exists in it as well.

Comment 2 Mark Tompsett 2012-06-29 14:30:53 UTC Comment hidden (obsolete)

Created attachment 10564 [details] [review]
Added a missing dereference marker for an array parameter.

As our library has been adding and editing lots of items, I have yet to see the bug resurface. I think the patch is self-evident.

Comment 3 Chris Cormack 2012-07-01 00:26:10 UTC

Created attachment 10576 [details] [review]
Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 4 Jonathan Druart 2012-07-02 14:19:03 UTC Comment hidden (obsolete)

Created attachment 10606 [details] [review]
Bug 8172: Followup: Removes useless empty params

QA Comment,

Your patch is good, but I think this one adds more readability (It removes empty params passed to buildQuery).

On the way, I replace an undefined variable ($debug with $DEBUG) in C4/Search.pm (introduces by the same commit 59f31b98361046af37646485f652f70e16a2e206, Bug 4116).

Switch back to need signed off

Comment 5 Chris Cormack 2012-08-06 08:08:33 UTC

Created attachment 11372 [details] [review]
Bug 8172: Followup: Removes useless empty params

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 6 Jonathan Druart 2012-08-09 10:09:00 UTC

Simple patch, Marked as Passed QA

Comment 7 Chris Cormack 2012-08-10 07:24:17 UTC

Pushed to 3.8.x will be in 3.8.4

Comment 8 Paul Poulain 2012-08-29 13:38:43 UTC

Pushed to master today. Already in stable, so status set accordingly