Bug 8188

Summary: OPAC allow hold date in future requires both OPAC and staff-side preferences to be ON
Product: Koha Reporter: Owen Leonard <oleonard>
Component: Hold requestsAssignee: Ian Walls <koha.sekjal>
Status: CLOSED INVALID QA Contact:
Severity: major    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Owen Leonard 2012-06-04 19:38:21 UTC
The OPAC's "Allow hold date in future" feature only works if the "AllowHoldDateInFuture" preference is enabled. Enabling the "OPACAllowHoldDateInFuture" preference has no effect.
Comment 1 Owen Leonard 2012-06-04 19:40:37 UTC
Correction: *both* preferences have to be turned on for it to work. This doesn't seem consistent with other similar features in Koha. Why does it require both?

# can set reserve date in future
if (
    C4::Context->preference( 'AllowHoldDateInFuture' ) &&
    C4::Context->preference( 'OPACAllowHoldDateInFuture' )
    ) {
    $template->param(
	    reserve_in_future         => 1,
    );
}
Comment 2 Owen Leonard 2014-07-11 13:56:18 UTC
The feature certainly seems to have been designed this way, and the documentation makes it clear that you must have both enabled. Since I don't have a vested interest in changing the behavior I'll consider this invalid.