Bug 8188 - OPAC allow hold date in future requires both OPAC and staff-side preferences to be ON
Summary: OPAC allow hold date in future requires both OPAC and staff-side preferences ...
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Target Milestone: ---
Assignee: Ian Walls
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 19:38 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-06-04 19:38:21 UTC
The OPAC's "Allow hold date in future" feature only works if the "AllowHoldDateInFuture" preference is enabled. Enabling the "OPACAllowHoldDateInFuture" preference has no effect.
Comment 1 Owen Leonard 2012-06-04 19:40:37 UTC
Correction: *both* preferences have to be turned on for it to work. This doesn't seem consistent with other similar features in Koha. Why does it require both?

# can set reserve date in future
if (
    C4::Context->preference( 'AllowHoldDateInFuture' ) &&
    C4::Context->preference( 'OPACAllowHoldDateInFuture' )
    ) {
    $template->param(
	    reserve_in_future         => 1,
    );
}
Comment 2 Owen Leonard 2014-07-11 13:56:18 UTC
The feature certainly seems to have been designed this way, and the documentation makes it clear that you must have both enabled. Since I don't have a vested interest in changing the behavior I'll consider this invalid.