Summary: | Enable critic tests on SIP modules | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, koha.sekjal, paul.poulain, stacey |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Signed off patch |
Description
Colin Campbell
2012-06-09 10:32:56 UTC
Created attachment 10006 [details] [review] Proposed patch Adds C4/SIP to critic tests To Test set environment variable TEST_QA to 1 from top level ran critic tests: prove t/00-testcritic.t no warnings should be generated Created attachment 10092 [details] [review] Signed off patch PBP patch; almost all changes to code are completely functionally equivalent to their old forms, but now conform to guidelines. Marking as Passed QA. Enabling more tests = win, pushed to 3.8.x |