Bug 8216

Summary: Enable critic tests on SIP modules
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: SIP2Assignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: chris, koha.sekjal, paul.poulain, stacey
Version: 3.10   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
Signed off patch

Description Colin Campbell 2012-06-09 10:32:56 UTC
Paul remarked in relation to pushing a fix for another bug that SIP modules continued to issue a number of perlcritic warnings. This patch will add C4/SIP to the testcritic diirectories and address those issues which are warnings (mainly return undef and subroutine prototypes) it also removes some dead code that was no longer used.
Comment 1 Colin Campbell 2012-06-09 10:40:35 UTC Comment hidden (obsolete)
Comment 2 stacey 2012-06-10 11:43:38 UTC
Created attachment 10092 [details] [review]
Signed off patch
Comment 3 Ian Walls 2012-06-11 13:52:13 UTC
PBP patch; almost all changes to code are completely functionally equivalent to their old forms, but now conform to guidelines.  Marking as Passed QA.
Comment 4 Chris Cormack 2012-06-22 08:14:00 UTC
Enabling more tests = win, pushed to 3.8.x