Paul remarked in relation to pushing a fix for another bug that SIP modules continued to issue a number of perlcritic warnings. This patch will add C4/SIP to the testcritic diirectories and address those issues which are warnings (mainly return undef and subroutine prototypes) it also removes some dead code that was no longer used.
Created attachment 10006 [details] [review]
Adds C4/SIP to critic tests
To Test set environment variable TEST_QA to 1
from top level ran critic tests:
no warnings should be generated
Created attachment 10092 [details] [review]
Signed off patch
PBP patch; almost all changes to code are completely functionally equivalent to their old forms, but now conform to guidelines. Marking as Passed QA.
Enabling more tests = win, pushed to 3.8.x