Summary: | Cannot search system preferences from Local Use tab | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | System Administration | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bmugambi, chris, gmcharlt, jonathan.druart, paul.poulain, veron |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 8261: Cannot search system preferences from Local Use tab |
Description
David Cook
2012-06-18 07:20:08 UTC
*** Bug 7522 has been marked as a duplicate of this bug. *** This bug was already reported by Bug 7522. I marked 7522 as duplicate. I can confirm the bug (Version 3.09.00.017 ) Marc Created attachment 11880 [details] [review] Proposed patch Very small patch. systempreferences.tt is using an old include sysprefs-admin-search.inc. New syspref system is using prefs-admin-search.inc include. So this patch sets prefs-admin-search.inc in systempreferences.tt and removes sysprefs-admin-search.inc file Created attachment 11884 [details] [review] Bug 8261: Cannot search system preferences from Local Use tab Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Maybe I have make a mistake but apparently there are 2 pages for manage syspref: admin/systempreferences.pl and admin/preferences.pl. This last one is used. And the corresponding tt files. Let me know if I forgot something, but I am under the impression we can remove the following files: admin/systempreferences.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc And we just replace the l.11 koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc [% IF ( local_use ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/admin/systempreferences.pl">Local use</a></li> Don't we need systempreferences.pl/.tt for Local use preferences? (In reply to comment #6) > Don't we need systempreferences.pl/.tt for Local use preferences? Yes :-/ But a big part of systempreferences.pl seems useless. I will open a new Bug. This one passes QA :) Patch pushed to master Pushed to 3.8.x, will be in 3.8.5 |