Summary: | overdue_notice.pl shows warning messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Nikhil <nikhilvr0> |
Component: | Notices | Assignee: | Nikhil <nikhilvr0> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, kyle, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8299 - overdue_notice.pl shows error messages
Bug 8299 - overdue_notice.pl shows error messages Bug 8299 - overdue_notice.pl shows error messages Bug 8299 - overdue_notice.pl shows error messages |
Description
Nikhil
2012-06-23 11:48:58 UTC
Created attachment 13996 [details] [review] Bug 8299 - overdue_notice.pl shows error messages fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. Created attachment 13997 [details] [review] Bug 8299 - overdue_notice.pl shows error messages fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. (In reply to comment #2) > Created attachment 13997 [details] [review] > Bug 8299 - overdue_notice.pl shows error messages > > fixes 2 warnings... how to test? run 'perl ./overdue_notice.pl -t' before and after applying patch no warnings should occur after patch is applied (patch applied to master 5d92ab39a681) Created attachment 14243 [details] [review] Bug 8299 - overdue_notice.pl shows error messages fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA Comments: On a technical point of view this patch is good because it tests if the variable is defined before passing it to a regexp. But the content of a letter should be defined. I think the real error is the last line of the log: No letter_code at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 686. So there is no letter defined for this overdue. Marked as Passed QA. It is a patch for master Created attachment 14259 [details] [review] Bug 8299 - overdue_notice.pl shows error messages fixes 2 warnings... Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659. Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.2 and 3.8.9 |