Summary: | Overdues email subject contains untranslatable 'Overdue:' string | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, f.demians, gaetan.boisson, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 8330: Overdue email link contains untranslatable 'Overdue:'
Bug 8330: Overdue email link contains untranslatable 'Overdue:' Bug 8330: Overdue email link contains untranslatable 'Overdue:' |
Description
Katrin Fischer
2012-06-28 12:44:07 UTC
*** Bug 8468 has been marked as a duplicate of this bug. *** I wonder if these links are ever used? Would be possible to instead generate a one-time notice? Hi Owen, an option so send a real mail from there using a notice template would certainly be much better! They are used in at least one library i know of. I think it makes sense to have this functionnality in a report that lists overdues. Even though i agree most libraries will choose to automate sending overdue notices. Some are small enough and would rather take care of it 100% manually, other might want to be able to send another notice, manually in some cases. Actually there used to be, i've seen it in libraries using an older version, a 'MANUAL_ODUE' notice, which would be sent from here. Hi Gaetan, yes, and we have been trying to make it work in the past - see bug 4990. Seems it was working in 2.2, then it got reintegrated in 3.0.x, while development was already done for 3.2. There never was a working patch for 3.2 (master back then), so the the feature got lost again after updating from 3.0.x. This is still valid. I think generating manual overdue emails could maybe be dealt with on bug 4990 and only fix the wrong string here for now. Created attachment 39962 [details] [review] Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Created attachment 40083 [details] [review] Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 40190 [details] [review] Bug 8330: Overdue email link contains untranslatable 'Overdue:' The translation scripts don't pick up text from href attributes, which is what we want, with a small exception for this script. Patch uses a TT trick to make the Overdue: in the subject of the mailto: link translatable. Regression test: - Make sure you have an overdue item - Go to Circulation > Overdues - Verify the [email] link works and a subject with 'Overdue: <title>' is generated - Apply patch and repeat steps Bonus: Verify the branch name now shows instead of the branchcode in the table To test translatability: - cd misc/translator - perl translate update de-DE - Open file po/de-DE-staff-prog.po - Search for Overdue: - Translate string, remove 'fuzzy' marker - perl translate install de-DE - Test again, subject should now be translated Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Patch pushed to master. Nice one Katrina! Pushed to 3.20.x will be in 3.20.2 |