| Summary: | Default checkout, hold and return policy for all library => wrong term | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
| Severity: | normal | ||
| Priority: | P2 | CC: | chris, claire.hernandez, gmcharlt, kyle.m.hall, kyle, mtj, nengard, veron |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 8362 | ||
| Attachments: |
Bug 8370: Change term issues (smart-rules)
Bug 8370: Change term issues (smart-rules) Bug 8370: Change term issues (smart-rules) |
||
|
Description
Paul Poulain
2012-07-05 13:54:46 UTC
Nicole, if you can do something with this bug and suggest a correct term (hoping you'll understand my description !) I think for "Default checkout, hold and return policy for all library" we can just remove the "for all libraries" part ... default to me implies a fall back. And then maybe change "Checkout limit by patron category for all libraries" to be "Default checkout limit by patron category" But I would think we might want to add something at the top of the ALL LIBRARIES rules to explain that if you only set those then they are applied to 'all libraries' but if you set specifics those are used instead - or something to make it clearer. Nicole That sounds like a good plan to me. Jonathan, if you could make a patch for fixing those term issues, that would be perfect ! Created attachment 12274 [details] [review] Bug 8370: Change term issues (smart-rules) I also change the "Holds policy by item type" part for more consistency. As Nicole pointed out in comment #2 the insturctions at the top of the page should be changed as well. Now the points regarding the defaults read as follows: all libraries, same patron type, same item type all libraries, same patron type, all item types all libraries, all patron types, same item type all libraries, all patron types, all item types It would be better to have e.g. default (all libraries), same patron type, same item type default (all libraries), same patron type, all item types default (all libraries), all patron types, same item type default (all libraries), all patron types, all item types Marc Created attachment 12297 [details] [review] Bug 8370: Change term issues (smart-rules) Created attachment 12304 [details] [review] Bug 8370: Change term issues (smart-rules) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to comment #9) > Created attachment 12304 [details] [review] > Bug 8370: Change term issues (smart-rules) > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> passing QA, patch looks good $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * 683bfd5 Bug 8370: Change term issues (smart-rules) koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt * koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK Patch pushed to master Follow-up suggestion: the page also says: For this library, you can specify the maximum number of loans that a patron of a given category can make, regardless of the item type. and For this library, you can edit rules for given itemtypes, regardless of the patron's category. Shouldn't we remove the "For this library" when you're on "All libraries" ? Released in 3.10.0 |