Bug 8370 - Default checkout, hold and return policy for all library => wrong term
Summary: Default checkout, hold and return policy for all library => wrong term
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.10
Hardware: All All
: P2 normal
Assignee: Jonathan Druart
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks: 8362
  Show dependency tree / graph
 
Reported: 2012-07-05 13:54 UTC by Paul Poulain
Modified: 2013-12-05 20:05 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8370: Change term issues (smart-rules) (2.61 KB, patch)
2012-09-17 12:18 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 8370: Change term issues (smart-rules) (3.57 KB, patch)
2012-09-18 08:24 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 8370: Change term issues (smart-rules) (3.66 KB, patch)
2012-09-18 12:40 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2012-07-05 13:54:46 UTC 
The string "Default checkout, hold and return policy for all library" that appear in issuingrules when you're on "All" library is wrong. It's related to the rule that is applied by default if there is no library-level rule.

Same problem with "Checkout limit by patron category for all libraries" and "Holds policy by itemtype for all libraries"
=> they refer to the behaviour if no library-level rule is set
Comment 1 Paul Poulain 2012-09-06 13:11:16 UTC 
Nicole, if you can do something with this bug and suggest a correct term (hoping you'll understand my description !)
Comment 2 Nicole C. Engard 2012-09-10 15:56:04 UTC 
I think for "Default checkout, hold and return policy for all library" we can just remove the "for all libraries" part ... default to me implies a fall back.

And then maybe change "Checkout limit by patron category for all libraries" to be "Default checkout limit by patron category"

But I would think we might want to add something at the top of the ALL LIBRARIES rules to explain that if you only set those then they are applied to 'all libraries' but if you set specifics those are used instead - or something to make it clearer.

Nicole
Comment 3 Kyle M Hall (khall) 2012-09-12 15:25:11 UTC 
That sounds like a good plan to me.
Comment 4 Paul Poulain 2012-09-17 10:15:04 UTC 
Jonathan, if you could make a patch for fixing those term issues, that would be perfect !
Comment 5 Jonathan Druart 2012-09-17 12:18:17 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2012-09-17 12:19:30 UTC 
I also change the "Holds policy by item type" part for more consistency.
Comment 7 Marc Véron 2012-09-17 15:34:06 UTC 
As Nicole pointed out in comment #2 the insturctions at the top of the page should be changed as well.

Now the points regarding the defaults read as follows:

all libraries, same patron type, same item type
all libraries, same patron type, all item types
all libraries, all patron types, same item type
all libraries, all patron types, all item types

It would be better to have e.g.

default (all libraries), same patron type, same item type
default (all libraries), same patron type, all item types
default (all libraries), all patron types, same item type
default (all libraries), all patron types, all item types

Marc
Comment 8 Jonathan Druart 2012-09-18 08:24:29 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall (khall) 2012-09-18 12:40:24 UTC 
Created attachment 12304 [details] [review]
Bug 8370: Change term issues (smart-rules)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Mason James 2012-10-03 00:36:54 UTC 
(In reply to comment #9)
> Created attachment 12304 [details] [review]
> Bug 8370: Change term issues (smart-rules)
> 
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

passing QA, patch looks good


$ koha-qa.pl -c 1

testing 1 commit(s) (applied to commit 0a35b26)
 * 683bfd5 Bug 8370: Change term issues (smart-rules)
      koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt

* koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt             OK
Comment 11 Paul Poulain 2012-10-05 14:24:42 UTC 
Patch pushed to master

Follow-up suggestion: the page also says:

For this library, you can specify the maximum number of loans that a patron of a given category can make, regardless of the item type. 

and

For this library, you can edit rules for given itemtypes, regardless of the patron's category. 

Shouldn't we remove the "For this library" when you're on "All libraries" ?
Comment 12 Chris Cormack 2013-04-20 23:32:00 UTC 
Released in 3.10.0