| Summary: | Some Perl scripts do not compile | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jared Camins-Esakov <jcamins> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P1 - high | CC: | chris, mtj, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 8384: Some Perl scripts do not compile
Bug 8384: Some Perl scripts do not compile |
||
|
Description
Jared Camins-Esakov
2012-07-09 02:13:29 UTC
Created attachment 10705 [details] [review] Bug 8384: Some Perl scripts do not compile Fix syntax errors preventing the scripts misc/translator/text-extract2.pl and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling. Remove misc/migration_tools/build6xx.pl entirely since it refers to columns that no longer exist in the Koha database, and has seemingly had broken encoding since Koha switched from CVS to git (or before!). Before the patch perl -I ../../ -c text-extract2.pl Bareword "TmplTokenType::TAG" not allowed while "strict subs" in use at text-extract2.pl line 45. Bareword "TmplTokenType::TEXT_PARAMETRIZED" not allowed while "strict subs" in use at text-extract2.pl line 53. text-extract2.pl had compilation errors. perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl syntax error at misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67, near "$IN open" Global symbol "$IN" requires explicit package name at misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67. misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl had compilation errors. After the patch perl -I ../../ -c text-extract2.pl text-extract2.pl syntax OK perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl syntax OK Created attachment 10706 [details] [review] Bug 8384: Some Perl scripts do not compile Fix syntax errors preventing the scripts misc/translator/text-extract2.pl and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling. Remove misc/migration_tools/build6xx.pl entirely since it refers to columns that no longer exist in the Koha database, and has seemingly had broken encoding since Koha switched from CVS to git (or before!). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> (In reply to comment #3) > Created attachment 10706 [details] [review] > Bug 8384: Some Perl scripts do not compile > > Fix syntax errors preventing the scripts misc/translator/text-extract2.pl > and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling. > > Remove misc/migration_tools/build6xx.pl entirely since it refers to > columns that no longer exist in the Koha database, and has seemingly > had broken encoding since Koha switched from CVS to git (or before!). > > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA comment... passing QA, trivial patch Pushed to 3.8.x, will be in 3.8.3 |