Bug 8384 - Some Perl scripts do not compile
Summary: Some Perl scripts do not compile
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.8
Hardware: All All
: P1 - high major
Assignee: Jared Camins-Esakov
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-09 02:13 UTC by Jared Camins-Esakov
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 8384: Some Perl scripts do not compile (16.07 KB, patch)
2012-07-09 02:31 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8384: Some Perl scripts do not compile (16.09 KB, patch)
2012-07-09 03:08 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-07-09 02:13:29 UTC
Three Perl scripts that are currently included in master do not compile: 
* misc/translator/text-extract2.pl
* misc/migration_tools/build6xx.pl
* misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl

They should.
Comment 1 Jared Camins-Esakov 2012-07-09 02:31:39 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-07-09 03:06:59 UTC
Before the patch

perl -I ../../ -c text-extract2.pl       
Bareword "TmplTokenType::TAG" not allowed while "strict subs" in use at text-extract2.pl line 45.
Bareword "TmplTokenType::TEXT_PARAMETRIZED" not allowed while "strict subs" in use at text-extract2.pl line 53.
text-extract2.pl had compilation errors.

 perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl 
syntax error at misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67, near "$IN open"
Global symbol "$IN" requires explicit package name at misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl line 67.
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl had compilation errors.

After the patch

perl -I ../../ -c text-extract2.pl              
text-extract2.pl syntax OK

perl -c misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl
misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl syntax OK
Comment 3 Chris Cormack 2012-07-09 03:08:01 UTC
Created attachment 10706 [details] [review]
Bug 8384: Some Perl scripts do not compile

Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Mason James 2012-07-09 20:15:00 UTC
(In reply to comment #3)
> Created attachment 10706 [details] [review]
> Bug 8384: Some Perl scripts do not compile
> 
> Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
> and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.
> 
> Remove misc/migration_tools/build6xx.pl entirely since it refers to
> columns that no longer exist in the Koha database, and has seemingly
> had broken encoding since Koha switched from CVS to git (or before!).
> 
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

QA comment...

passing QA, trivial patch
Comment 5 Chris Cormack 2012-07-10 20:23:08 UTC
Pushed to 3.8.x, will be in 3.8.3