| Summary: | Map ︡a to a and t︠ to t for searching (Non-ICU) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
| Component: | Searching - Zebra | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, martin.renvoize, nick, oleonard, paul.poulain, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35621 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.04,20.05.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 8426 - Diacritics not being mapped for searching
Example MARC file that uses these diacritics. Bug 8426: (follow-up) Similar changes for Ž and ž Bug 8426 - Diacritics not being mapped for searching Bug 8426: Diacritics not being mapped for searching |
||
|
Description
Kyle M Hall
2012-07-12 11:06:53 UTC
Created attachment 10783 [details] [review] Bug 8426 - Diacritics not being mapped for searching Add mappings for ︡a to a, and for t︠ to t. Created attachment 10784 [details]
Example MARC file that uses these diacritics.
Hi Kyle, I think indexing using ICU might fix this problem. I think it could get hard to add all possible combinations to the mapping. The library having this problem is already using ICU, and they are still experiencing this problem. (In reply to comment #4) > The library having this problem is already using ICU, and they are still > experiencing this problem. If this patch has any effect, it means that Zebra has not been configured properly for ICU. Also, these ligatures are used very commonly in Russian transliteration. It's not just for ts. (In reply to comment #5) > (In reply to comment #4) > > The library having this problem is already using ICU, and they are still > > experiencing this problem. > > If this patch has any effect, it means that Zebra has not been configured > properly for ICU. I confirm : *.chr are not used in ICU mode I think failed QA is the proper status for this patch ;-) Kyle, is your patch still needed? I think we could probably add the mapping for libraries not using ICU, but also using ICU should fix the problem. I have learned since that ICU doesn't support some things - so it does make sense to maintain these mappings. Is this patch still relevant? Comments here are contradictory. If this should still be tested please provide a detailed test plan. Created attachment 81722 [details] [review] Bug 8426: (follow-up) Similar changes for Ž and ž To test: 1 - Find or add a record by author Slavoj Žižek 2 - Search for 'Zizek' 3 - No results 4 - Apply patch 5 - Reindex 6 - Search again 7 - Success! (In reply to Owen Leonard from comment #9) > Is this patch still relevant? Comments here are contradictory. If this > should still be tested please provide a detailed test plan. Still relevant, plan for Kyle's patch is similar to follow-up: 1 - Import the sample record 2 - Search for Zhar-ptitsa 3 - No result 4 - Apply patch 5 - You may need to cp word-phrase-utf.chr from /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to /etc/koha/zebradb/etc/word-phrase-utf.chr (backup your original first) 6 - Reindex zebra 7 - Search again, you should get result (In reply to Nick Clemens from comment #11) > (In reply to Owen Leonard from comment #9) > > Is this patch still relevant? Comments here are contradictory. If this > > should still be tested please provide a detailed test plan. > > Still relevant, plan for Kyle's patch is similar to follow-up: > > 1 - Import the sample record > 2 - Search for Zhar-ptitsa > 3 - No result > 4 - Apply patch > 5 - You may need to cp word-phrase-utf.chr from > /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to > /etc/koha/zebradb/etc/word-phrase-utf.chr > (backup your original first) > 6 - Reindex zebra > 7 - Search again, you should get result Z problems moved to bug 22073 as the patches for original issue don't seem to work Created attachment 117434 [details] [review] Bug 8426 - Diacritics not being mapped for searching Add mappings for ︡a to a, and for t︠ to t. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 117736 [details] [review] Bug 8426: Diacritics not being mapped for searching Add mappings for ︡a to a, and for t︠ to t. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The indentation on this file is a bit problematic. The new entries use spaces, but oveall this file uses tabs. I was pondering a follow-up, but couldn't quite decide which direction I should fix. Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |