Bug 8426 - Diacritics not being mapped for searching (Non-ICU)
Summary: Diacritics not being mapped for searching (Non-ICU)
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 11:06 UTC by Kyle M Hall
Modified: 2019-01-07 14:31 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8426 - Diacritics not being mapped for searching (941 bytes, patch)
2012-07-12 11:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Example MARC file that uses these diacritics. (1.11 KB, application/octet-stream)
2012-07-12 11:09 UTC, Kyle M Hall
Details
Bug 8426: (follow-up) Similar changes for Ž and ž (939 bytes, patch)
2018-10-31 12:52 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-07-12 11:06:53 UTC
Most of the uniform titles for Stravinsky’s music (and other Russian
composers) is in Russian.  So the uniform title for the ballet music, Firebird,
is Zhar-ptit︠s︡a which is actually two diacritics (left and right ligatures
combined). Right now it’s not searchable unless you include the ligatures in
the search term.
Comment 1 Kyle M Hall 2012-07-12 11:08:27 UTC
Created attachment 10783 [details] [review]
Bug 8426 - Diacritics not being mapped for searching

Add mappings for ︡a to a, and for t︠ to t.
Comment 2 Kyle M Hall 2012-07-12 11:09:24 UTC
Created attachment 10784 [details]
Example MARC file that uses these diacritics.
Comment 3 Katrin Fischer 2012-07-12 11:13:31 UTC
Hi Kyle, I think indexing using ICU might fix this problem. I think it could get hard to add all possible combinations to the mapping.
Comment 4 Kyle M Hall 2012-07-12 11:58:18 UTC
The library having this problem is already using ICU, and they are still experiencing this problem.
Comment 5 Jared Camins-Esakov 2012-07-12 13:49:53 UTC
(In reply to comment #4)
> The library having this problem is already using ICU, and they are still
> experiencing this problem.

If this patch has any effect, it means that Zebra has not been configured properly for ICU. Also, these ligatures are used very commonly in Russian transliteration. It's not just for ts.
Comment 6 Paul Poulain 2012-07-12 15:05:35 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > The library having this problem is already using ICU, and they are still
> > experiencing this problem.
> 
> If this patch has any effect, it means that Zebra has not been configured
> properly for ICU.
I confirm : *.chr are not used in ICU mode

I think failed QA is the proper status for this patch ;-)
Comment 7 Katrin Fischer 2013-04-14 08:17:45 UTC
Kyle, is your patch still needed? I think we could probably add the mapping for libraries not using ICU, but also using ICU should fix the problem.
Comment 8 Katrin Fischer 2016-08-14 19:20:18 UTC
I have learned since that ICU doesn't support some things - so it does make sense to maintain these mappings.
Comment 9 Owen Leonard 2017-04-10 16:59:56 UTC
Is this patch still relevant? Comments here are contradictory. If this should still be tested please provide a detailed test plan.
Comment 10 Nick Clemens 2018-10-31 12:52:47 UTC Comment hidden (obsolete)
Comment 11 Nick Clemens 2018-10-31 12:56:08 UTC
(In reply to Owen Leonard from comment #9)
> Is this patch still relevant? Comments here are contradictory. If this
> should still be tested please provide a detailed test plan.

Still relevant, plan for Kyle's patch is similar to follow-up:

1 - Import the sample record
2 - Search for Zhar-ptitsa
3 - No result
4 - Apply patch
5 - You may need to cp word-phrase-utf.chr from /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to /etc/koha/zebradb/etc/word-phrase-utf.chr
(backup your original first)
6 - Reindex zebra
7 - Search again, you should get result
Comment 12 Nick Clemens 2019-01-07 14:30:44 UTC
(In reply to Nick Clemens from comment #11)
> (In reply to Owen Leonard from comment #9)
> > Is this patch still relevant? Comments here are contradictory. If this
> > should still be tested please provide a detailed test plan.
> 
> Still relevant, plan for Kyle's patch is similar to follow-up:
> 
> 1 - Import the sample record
> 2 - Search for Zhar-ptitsa
> 3 - No result
> 4 - Apply patch
> 5 - You may need to cp word-phrase-utf.chr from
> /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to
> /etc/koha/zebradb/etc/word-phrase-utf.chr
> (backup your original first)
> 6 - Reindex zebra
> 7 - Search again, you should get result

Z problems moved to bug 22073 as the patches for original issue don't seem to work