Bug 8474

Summary: Holds done by librarians cause silent errors in koha-error_log
Product: Koha Reporter: Piotr Kowalski <kolpen>
Component: Hold requestsAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P5 - low CC: chris, gmcharlt, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patches to request.pl and placerequest.pl modules
Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem
Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem
[PASSED QA] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem

Description Piotr Kowalski 2012-07-19 11:14:39 UTC Comment hidden (obsolete)
Comment 1 Owen Leonard 2013-08-13 16:53:57 UTC
This bug still affects master, but the patch isn't formatted correctly to even try to apply.
Comment 2 Katrin Fischer 2014-07-12 12:07:27 UTC
*** Bug 8531 has been marked as a duplicate of this bug. ***
Comment 3 Olli-Antti Kivilahti 2014-07-23 08:17:08 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-04-13 09:12:51 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-04-15 21:48:42 UTC
Created attachment 37932 [details] [review]
[PASSED QA] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem

Squashed this rogue variable initialization

Test plan:
1/ Place a hold at a biblio level (on the next available item)
2/ Without this patch you get
placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 75.
placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 101.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a tab.
Comment 6 Tomás Cohen Arazi 2015-04-23 16:14:01 UTC
Patch pushed to master.

we love removing useless warnings, thanks Olli!
Comment 7 Chris Cormack 2015-05-11 22:47:54 UTC
Pushed to 3.18.x will be in 3.18.7