Summary: | Holds done by librarians cause silent errors in koha-error_log | ||
---|---|---|---|
Product: | Koha | Reporter: | Piotr Kowalski <kolpen> |
Component: | Hold requests | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patches to request.pl and placerequest.pl modules
Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem [PASSED QA] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem |
This bug still affects master, but the patch isn't formatted correctly to even try to apply. *** Bug 8531 has been marked as a duplicate of this bug. *** Created attachment 29964 [details] [review] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization Created attachment 37715 [details] [review] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization Test plan: 1/ Place a hold at a biblio level (on the next available item) 2/ Without this patch you get placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 75. placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 101. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 37932 [details] [review] [PASSED QA] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization Test plan: 1/ Place a hold at a biblio level (on the next available item) 2/ Without this patch you get placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 75. placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 101. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tab. Patch pushed to master. we love removing useless warnings, thanks Olli! Pushed to 3.18.x will be in 3.18.7 |
Created attachment 11000 [details] Proposed patches to request.pl and placerequest.pl modules Silent errors occur in koha-error_log when a librarian makes holds for borrowers. The reasons are uninitialized values in modules (intranet/cgi-bin/reserve): - request.pl - placerequest.pl Proposed patches refer to Koha 3.6.4 version as well as 3.6.6