Summary: | C4::Installer::PerlDependencies needs Test::Strict hash corrected | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Galen Charlton <gmcharlt> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, m.de.rooy |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line |
Description
Mark Tompsett
2012-07-21 08:05:45 UTC
Created attachment 11060 [details] [review] Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line Before the patch: koha_perl_deps.pl -a should generate an error on Test::Strict After the patch: koha_perl_deps.pl -a should not generate an error on Test::Strict (In reply to comment #1) > Created attachment 11060 [details] [review] > Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line > > Before the patch: > koha_perl_deps.pl -a should generate an error on Test::Strict > After the patch: > koha_perl_deps.pl -a should not generate an error on Test::Strict I'm not sure Test::Strict is required, I think it could be 0. Its only used by one database dependent test, so will not be run when calling make test. If you rework the patch to make it not required, I'll sign off. |