Summary: | Javascript error when creating a new order | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Acquisitions | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 8495: Fix JS error when creating a new order
Bug 8495: Fix JS error when creating a new order Bug 8495: Fix JS error when creating a new order |
Description
Julian Maurice
2012-07-24 10:23:12 UTC
Created attachment 11101 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 Created attachment 11106 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> (In reply to comment #2) > Created attachment 11106 [details] [review] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> hmmm, we are waiting for a 'non BibLibre' sign-off here, before QA? i will change status to 'needs-signoff' (i hope that is ok?) Created attachment 11524 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> (In reply to comment #4) > Created attachment 11524 [details] [review] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * cf863e0 Bug 8495: Fix JS error when creating a new order koha-tmpl/intranet-tmpl/prog/en/js/additem.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK patch pushed today Pushed to 3.8.x, will be in 3.8.5 Ok in master and 3.8.x. Marked as RESOLVED. |