Steps to reproduce: - syspref AcqCreateItem='ordering' - syspref UniqueItemFields='barcode' (or something else, but not empty) - with Firebug, enable the 'persistent' mode, so you can see the error message even after form is submitted - create a new order, add 1 item, select a budget and click on save. - you should see in firebug an error like this : "Syntax error, unrecognized expression: [value=items.barcode]". This cause the form to be submitted too early in the validation process. Patch is coming.
Created attachment 11101 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178
Created attachment 11106 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to comment #2) > Created attachment 11106 [details] [review] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> hmmm, we are waiting for a 'non BibLibre' sign-off here, before QA? i will change status to 'needs-signoff' (i hope that is ok?)
Created attachment 11524 [details] [review] Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
(In reply to comment #4) > Created attachment 11524 [details] [review] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * cf863e0 Bug 8495: Fix JS error when creating a new order koha-tmpl/intranet-tmpl/prog/en/js/additem.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
patch pushed today
Pushed to 3.8.x, will be in 3.8.5
Ok in master and 3.8.x. Marked as RESOLVED.