Summary: | Allowing the Expected status even if another status has been saved | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | Serials | Assignee: | Adrien SAURAT <adrien.saurat> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | colin.campbell, melia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
[Signed off] Bug 8509: allows the Expected status to be chosen back Bug 8509: allows the Expected status to be chosen back [PASSED QA] Bug 8509: allows the Expected status to be chosen back |
Description
Adrien SAURAT
2012-07-26 09:38:27 UTC
Created attachment 12396 [details] [review] proposed patch TEST PLAN Receive serials. Change a serial from Expected to another status. Come back to the receive page. Before patch : the serial cannot be set to Expected anymore After patch : the Expected status still appear in the select box and can be used Created attachment 13327 [details] [review] [Signed off] Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Before applying the patch, I selected the status "arrived." I then went back to the receive page, clicked on edit, and found it was not possible for me to go back to "expected" because it did not appear as a choice in the status dropdown menu. After applying the patch, I can go back to "expected." I am signing off. One question I'd like to ask, though: After changing back to status "expected," if you go back to the receive page, the Date Received is still filled in there. Is this correct? I would think if you were going back to "expected" it would be because you had accidentally marked it "arrived." Perhaps when you go back to "expected," the date received should go back to XXX like it was before I marked it "arrived." I am not 100% sure about use cases here, so I'll go ahead and sign off. Maybe the date received could be fixed (if necessary) in a follow up patch? Hi Adrien, there is a small conflict with the patch, could you rebase? I am a bit worried about the problem Melia noticed and I wonder what will happen when you create items with your subscription. Created attachment 14739 [details] [review] Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Created attachment 16550 [details] [review] [PASSED QA] Bug 8509: allows the Expected status to be chosen back If a serial has been marked as received by mistake, it's now possible to set it as an "Expected" serial again. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. I did varoius tests on a subscription switching between the different status (expected, arrived, late) and couldn't find a bad side effect of this patch. Note: The date arrived/date expected is not automatically reset, but you can enter the date manually in the template, so I think this could be handled in a separate bug. This patch has been pushed to master. |