Bug 8509 - Allowing the Expected status even if another status has been saved
Summary: Allowing the Expected status even if another status has been saved
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Adrien SAURAT
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 09:38 UTC by Adrien SAURAT
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.12 KB, patch)
2012-09-20 14:20 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[Signed off] Bug 8509: allows the Expected status to be chosen back (1.21 KB, patch)
2012-11-08 21:18 UTC, Melia Meggs
Details | Diff | Splinter Review
Bug 8509: allows the Expected status to be chosen back (1.22 KB, patch)
2013-01-22 09:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 8509: allows the Expected status to be chosen back (1.62 KB, patch)
2013-03-20 16:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-07-26 09:38:27 UTC
When receiving Serials, if a librarian selects a status like "Arrived" or something else, it's later impossible to go back to the initial "Expected" status.

This makes mistakes impossible to correct. Maybe would it be better to display the "Expected" status in the modification selectbox.
Comment 1 Adrien SAURAT 2012-09-20 14:20:43 UTC Comment hidden (obsolete)
Comment 2 Melia Meggs 2012-11-08 21:18:48 UTC Comment hidden (obsolete)
Comment 3 Melia Meggs 2012-11-08 21:19:31 UTC
Before applying the patch, I selected the status "arrived."  I then went back to the receive page, clicked on edit, and found it was not possible for me to go back to "expected" because it did not appear as a choice in the status dropdown menu.

After applying the patch, I can go back to "expected."

I am signing off.

One question I'd like to ask, though:
After changing back to status "expected," if you go back to the receive page, the Date Received is still filled in there.  Is this correct?  I would think if you were going back to "expected" it would be because you had accidentally marked it "arrived."  Perhaps when you go back to "expected," the date received should go back to XXX like it was before I marked it "arrived."

I am not 100% sure about use cases here, so I'll go ahead and sign off.  Maybe the date received could be fixed (if necessary) in a follow up patch?
Comment 4 Katrin Fischer 2012-12-02 19:47:03 UTC
Hi Adrien,

there is a small conflict with the patch, could you rebase?

I am a bit worried about the problem Melia noticed and I wonder what will happen when you create items with your subscription.
Comment 5 Jonathan Druart 2013-01-22 09:44:42 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-03-20 16:54:39 UTC
Created attachment 16550 [details] [review]
[PASSED QA] Bug 8509: allows the Expected status to be chosen back

If a serial has been marked as received by mistake, it's now
possible to set it as an "Expected" serial again.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

I did varoius tests on a subscription switching between the
different status (expected, arrived, late) and couldn't find
a bad side effect of this patch.

Note: The date arrived/date expected is not automatically reset,
but you can enter the date manually in the template, so I think
this could be handled in a separate bug.
Comment 7 Jared Camins-Esakov 2013-03-21 22:58:38 UTC
This patch has been pushed to master.