Summary: | Old/iffy data causes error checking out | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Circulation | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P3 | CC: | chris, christophe.croullebois, gmcharlt, jonathan.druart, kyle.m.hall, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 8532 - improve robustness when converting dates
Bug 8532 - improve robustness when converting dates |
Description
Robin Sheat
2012-07-31 11:20:13 UTC
Created attachment 11216 [details] [review] Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. This should be put into 3.8 also. Created attachment 11261 [details] [review] Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I replace "return undef" with just "return" to pass perlcritic *** Bug 8537 has been marked as a duplicate of this bug. *** Marcel if you could QA this, that would be fantastic! Tiny patch, handling passed undefs. Passed QA Pushed to 3.8.x, will be in 3.8.4 pushed to master. Already on stable, changing status accordingly |