Summary: | DataTables upgrade broke display of next/previous buttons in table controls | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, cnighswonger, dcook, mtj, nengard, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Screenshot showing the problem
Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls |
*** Bug 8592 has been marked as a duplicate of this bug. *** Created attachment 11455 [details] [review] Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). Created attachment 11459 [details] [review] Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Fix works well. (In reply to comment #3) > Created attachment 11459 [details] [review] > Bug 8549 - DataTables upgrade broke display of next/previous buttons in > table controls > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> patch looks good, passing QA fyi: we need to add .css and .js validation tests to qa-tools too... :) mason@xen1:~/git/head$ koha-qa.pl * 35aa6ba Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls koha-tmpl/intranet-tmpl/prog/en/css/datatables.css koha-tmpl/intranet-tmpl/prog/en/js/datatables.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK *** Bug 8695 has been marked as a duplicate of this bug. *** Patch pushed to master. (Not sure the commit e77461a3cfb18a851668b99d9d6d323b9fefceb4 that introduced the problem is in 3.8, so maybe not for 3.8) Not needed for 3.8.x |
Created attachment 11272 [details] Screenshot showing the problem commit e77461a3cfb18a851668b99d9d6d323b9fefceb4, "Upgrading DataTables library to 1.9.1" broke the display of the next/previous buttons on DataTables table controls. Link text overlays the button images.