Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls
Summary: DataTables upgrade broke display of next/previous buttons in table controls
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
: 8592 8695 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-01 16:45 UTC by Owen Leonard
Modified: 2018-10-06 07:21 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the problem (13.14 KB, image/png)
2012-08-01 16:45 UTC, Owen Leonard
Details
Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls (8.51 KB, patch)
2012-08-08 18:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls (8.52 KB, patch)
2012-08-08 21:39 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-08-01 16:45:29 UTC
Created attachment 11272 [details]
Screenshot showing the problem

commit e77461a3cfb18a851668b99d9d6d323b9fefceb4, "Upgrading DataTables library to 1.9.1" broke the display of the next/previous buttons on DataTables table controls. Link text overlays the button images.
Comment 1 Owen Leonard 2012-08-08 12:27:27 UTC
*** Bug 8592 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2012-08-08 18:22:01 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2012-08-08 21:39:01 UTC
Created attachment 11459 [details] [review]
Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls

When the DataTables plugin was upgraded the DataTables CSS
was not updated at the same time, causing problems in the
display due to changes in how the plugin works.

The DataTables upgrade added text lables to the image-only
buttons in order to improve accessibility. This patch
revises the CSS and the four_button pager modification
to conform with the upgrade.

To test, please view tables which use each of three types of
pagers: default two-button (ex: circ/pendingreserves),
custom four-button (ex: members/readingrec.pl) and full
(ex: tools/quotes.pl).

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Chris Cormack 2012-08-08 21:40:07 UTC
Fix works well.
Comment 5 Mason James 2012-08-10 07:19:01 UTC
(In reply to comment #3)
> Created attachment 11459 [details] [review]
> Bug 8549 - DataTables upgrade broke display of next/previous buttons in
> table controls
>  
> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

patch looks good, passing QA

fyi: we need to add .css and .js validation tests to qa-tools too... :)



mason@xen1:~/git/head$ koha-qa.pl
        * 35aa6ba Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls
                koha-tmpl/intranet-tmpl/prog/en/css/datatables.css
                koha-tmpl/intranet-tmpl/prog/en/js/datatables.js

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK
Comment 6 Owen Leonard 2012-08-28 14:59:04 UTC
*** Bug 8695 has been marked as a duplicate of this bug. ***
Comment 7 Paul Poulain 2012-09-04 16:33:13 UTC
Patch pushed to master.
(Not sure the commit e77461a3cfb18a851668b99d9d6d323b9fefceb4 that introduced the problem is in 3.8, so maybe not for 3.8)
Comment 8 Chris Cormack 2012-09-05 10:18:32 UTC
Not needed for 3.8.x