| Summary: | Icon for scores on OPAC detail page broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
screenshot
Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken |
||
I can't reproduce this bug in current master. Hi Owen, I retested, I see it in 3.6.3 and 3.8.x - not on master. Created attachment 13453 [details] [review] Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken At some point some famfamfam icons were moved out of the theme director into the lib directory in opac-tmpl. When this was done the path to the directory was changed accordingly in most cases. However, not all famfamfam icons were moved, and some image paths were not corrected. This patch completes the move of the famfamfam icon set to opac-tmpl/lib and corrects the path to the icons on the OPAC XSL detail page and the OPAC holds page. To test, view those pages and confirm that the images work. View records with a variety of material types. I tried applying this on 3.8.x Using index info to reconstruct a base tree... error: patch failed: koha-tmpl/opac-tmpl/prog/famfamfam/mini/readme.txt:1 error: koha-tmpl/opac-tmpl/prog/famfamfam/mini/readme.txt: patch does not apply error: patch failed: koha-tmpl/opac-tmpl/prog/famfamfam/readme.txt:1 error: koha-tmpl/opac-tmpl/prog/famfamfam/readme.txt: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. Created attachment 13784 [details] [review] Bug 8614 [3.8.x] Icon for scores on OPAC detail page broken At some point some famfamfam icons were moved out of the theme director into the lib directory in opac-tmpl. When this was done the path to the directory was changed accordingly in most cases. However, not all famfamfam icons were moved, and some image paths were not corrected. This patch completes the move of the famfamfam icon set to opac-tmpl/lib and corrects the path to the icons on the OPAC XSL detail page and the OPAC holds page. To test, view those pages and confirm that the images work. View records with a variety of material types. Edit: Rebased on origin/3.8.x Pushed to 3.8.x, thank you Owen |
Created attachment 11520 [details] screenshot The icon for scores on the OPAC detail page is not displaying correctly, instead following text is shown: Type: materialTypeLabelScore In other cases the score icon shows up on the result list, but on the detail page the article icon or the book is shown. It seems that different conditions are used to determine which icon to display on both pages.