Description
Marc Véron
2012-08-14 18:24:02 UTC
Created attachment 11619 [details] [review] Bug 8641 - Add information warning about log-in as root user to About->System information Add warning to 'About->System information' if an user is logged in as database admiinsitrative user (root user). Created attachment 11620 [details] [review] Bug 8641 - Add information warning about log-in as root user to About->System information Add warning to 'About->System information' if an user is logged in as database admiinsitrative user (root user). Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Interesting information to display. Marked as Passed QA. Patch pushed to master. I would not object having this warning more prominent, like: * appearing on mainpage.pl * appearing in red on about.pl & on the 1st tab displayed As it is now, I feel it won't be seen by a lot of ppl Created attachment 13686 [details] [review] Bug 8641 [Follow-up] Add warning about log-in as root user to About page Correction for incorrect term: Koha uses the word "library" instead of "branch." Before applying patch, on the About Koha > System Information page, I see: Warning regarding current user It seems that you are logged in as database administrative user. A lot of things will not work with this account. Usually you need to log in with a regular staff account. To create a staff account, create a branch, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar. After applying patch, I see: Warning regarding current user It seems that you are logged in as database administrative user. A lot of things will not work with this account. Usually you need to log in with a regular staff account. To create a staff account, create a library, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar. "Create a branch" has been successfully changed to "create a library," so I am signing off. Created attachment 13694 [details] [review] [Signed off] Bug 8641 [Follow-up] Add warning about log-in as root user to About page Correction for incorrect term: Koha uses the word "library" instead of "branch." Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Also, this is just a matter of personal preference, but I think the wording of this message sounds somehow not quite right. I don't know what it is... maybe it just doesn't sound very confident, perhaps? I might rewrite it to be more authoritative, like this: "You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account. Please log in instead with a regular staff account. To create a staff account, create a library, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar." That has the same meaning but a different tone. Not sure if it's worth the effort of someone writing another patch to change the wording when it carries basically the same meaning, but I thought I'd put the suggestion out there. :) Melia, Thank you for your comment. You are very welcome to change the wording as I am not a native speaker. :-) Marc Created attachment 13719 [details] [review] [SIGNED-OFF] Bug 8641 [Follow-up] Add warning about log-in as root user to About page Correction for incorrect term: Koha uses the word "library" instead of "branch." Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass and wording changed. Created attachment 13742 [details] [review] Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information The wording of this message sounds strange to a native speaker. Reword it. I was a bit too slow, but here is a patch that just rewords this message. I didn't realize until I attached it that the last patch had already Passed QA, so now we've got one patch attached here that has Passed QA, and another follow up patch that needs signoff. Not sure what to do about the status? I think this should be easy to sign-off - so resetting status and both patches can hopefully be pushed together soon. Created attachment 13751 [details] [review] [SIGNED-OFF] Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information The wording of this message sounds strange to a native speaker. Reword it. Signed-off-by: Marc Veron <veron@veron.ch> New wording appears as expected on about page. Looks like everything is signed off now, so I'm just changing the status back to "signed off." Created attachment 13825 [details] [review] [SIGNED-OFF] Bug 8641 [Follow-up] Add warning about log-in as root user to About page Correction for incorrect term: Koha uses the word "library" instead of "branch." Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass and wording changed. Created attachment 13826 [details] [review] [SIGNED-OFF] Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information The wording of this message sounds strange to a native speaker. Reword it. Signed-off-by: Marc Veron <veron@veron.ch> New wording appears as expected on about page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, new wording shows up. To test: 1) Login with your normal user - no warning is shown on about page 2) Login with the root/database user - warning is shown on about page This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.1 |