Summary: | Fix background-job-progressbar.js for translations | ||
---|---|---|---|
Product: | Koha | Reporter: | Maxime Pelletier <pelletiermaxime> |
Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED INVALID | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, chris, f.demians, jonathan.druart, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Small patch to fix
[SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations |
Description
Maxime Pelletier
2012-08-14 22:01:30 UTC
Created attachment 11623 [details] [review] Small patch to fix Created attachment 11627 [details] [review] [SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations Respect coding guidelines for translations in javascript by replacing ' by ". Fixes the page for the french translation (that contains a '). Sponsored by the CCSR. http://bugs.koha-community.org/show_bug.cgi?id=8645 Signed-off-by: Owen Leonard <oleonard@myacpl.org> This patch clearly does no harm, so I will trust that it does good. Signed off. Hi Maxime, This patch does not work for me. I think the .js files are not translatable. Could someone confirm that ? (In reply to comment #4) > Hi Maxime, > > This patch does not work for me. I think the .js files are not translatable. > Could someone confirm that ? Well, damn. Forgot to add a _() in the patch to allow to be translatable. Will upload a new patch in a few hours. Is that what this patch is supposed to enable? JavaScript files are not translatable. Translatable strings should be moved to the template: http://wiki.koha-community.org/wiki/Coding_Guidelines#Enabling_translation_of_language_strings_in_linked_JavaScript Arg. Yeah... the code was in an .inc file in 3.6 and I just merged my code in the .js without thinking about it. I will try to fix it to make it translatable in a template. Thanks. Still valid? (In reply to Marc Véron from comment #8) > Still valid? Yes. There is still one English string in background-job-progressbar.js at line 72: alert('Failed to submit form: ' + textStatus); (In reply to Owen Leonard from comment #9) > (In reply to Marc Véron from comment #8) > > Still valid? > > Yes. There is still one English string in background-job-progressbar.js at > line 72: > > alert('Failed to submit form: ' + textStatus); Still valid. Resetting assignee (last comment was 2016) (In reply to Katrin Fischer from comment #10) > Still valid. > The file and the string are no more present, I think this is now invalid |