Bug 8645 - Fix background-job-progressbar.js for translations
Summary: Fix background-job-progressbar.js for translations
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 22:01 UTC by Maxime Pelletier
Modified: 2020-11-30 21:45 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Small patch to fix (1.12 KB, patch)
2012-08-14 22:01 UTC, Maxime Pelletier
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations (1.33 KB, patch)
2012-08-15 14:25 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Pelletier 2012-08-14 22:01:30 UTC
Respect coding guidelines for translations in javascript by replacing ' by ". Fixes the page for the fr-CA translation (that contains a ').
Comment 1 Maxime Pelletier 2012-08-14 22:01:55 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-08-15 14:25:38 UTC
Created attachment 11627 [details] [review]
[SIGNED-OFF] Bug 8645 - Fix background-job-progressbar.js for translations

Respect coding guidelines for translations in javascript by replacing ' by ".
Fixes the page for the french translation (that contains a ').
Sponsored by the CCSR.

http://bugs.koha-community.org/show_bug.cgi?id=8645
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2012-08-15 14:26:47 UTC
This patch clearly does no harm, so I will trust that it does good. Signed off.
Comment 4 Jonathan Druart 2012-08-16 14:56:29 UTC
Hi Maxime,

This patch does not work for me. I think the .js files are not translatable.
Could someone confirm that ?
Comment 5 Maxime Pelletier 2012-08-16 15:10:12 UTC
(In reply to comment #4)
> Hi Maxime,
> 
> This patch does not work for me. I think the .js files are not translatable.
> Could someone confirm that ?

Well, damn. Forgot to add a _() in the patch to allow to be translatable. Will upload a new patch in a few hours.
Comment 6 Owen Leonard 2012-08-16 15:20:39 UTC
Is that what this patch is supposed to enable? JavaScript files are not translatable. Translatable strings should be moved to the template: http://wiki.koha-community.org/wiki/Coding_Guidelines#Enabling_translation_of_language_strings_in_linked_JavaScript
Comment 7 Maxime Pelletier 2012-08-16 15:42:55 UTC
Arg. Yeah... the code was in an .inc file in 3.6 and I just merged my code in the .js without thinking about it.
I will try to fix it to make it translatable in a template.
Thanks.
Comment 8 Marc Véron 2016-08-19 12:15:46 UTC
Still valid?
Comment 9 Owen Leonard 2016-08-19 12:34:49 UTC
(In reply to Marc Véron from comment #8)
> Still valid?

Yes. There is still one English string in background-job-progressbar.js at line 72:

      alert('Failed to submit form: ' + textStatus);
Comment 10 Katrin Fischer 2019-04-28 12:24:25 UTC
(In reply to Owen Leonard from comment #9)
> (In reply to Marc Véron from comment #8)
> > Still valid?
> 
> Yes. There is still one English string in background-job-progressbar.js at
> line 72:
> 
>       alert('Failed to submit form: ' + textStatus);

Still valid.

Resetting assignee (last comment was 2016)
Comment 11 Bernardo Gonzalez Kriegel 2020-04-28 19:11:33 UTC
(In reply to Katrin Fischer from comment #10)
> Still valid.
> 

The file and the string are no more present, I think this is now invalid