Summary: | XSLT stylesheets output XML, but HTML is needed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | OPAC | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, fridolin.somers, jonathan.druart, paul.poulain, tomascohen |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 8678: XSLT stylesheets output XML, but HTML is needed
Bug 8678: XSLT stylesheets output XML, but HTML is needed |
Description
Jared Camins-Esakov
2012-08-23 16:21:54 UTC
Created attachment 11798 [details] [review] Bug 8678: XSLT stylesheets output XML, but HTML is needed Because we are embedding the results of XSLT stylesheets in HTML, we need to output HTML instead of XML. Outputting XML results in non-standard-compliant (or at least non-Firefox-compliant) markup. To test: View a variety of XSLT-rendered pages on the OPAC and intranet, and confirm that all look as expected. Created attachment 11802 [details] [review] Bug 8678: XSLT stylesheets output XML, but HTML is needed Because we are embedding the results of XSLT stylesheets in HTML, we need to output HTML instead of XML. Outputting XML results in non-standard-compliant (or at least non-Firefox-compliant) markup. To test: View a variety of XSLT-rendered pages on the OPAC and intranet, and confirm that all look as expected. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Tested both on master and 3.8.x. Perfect, I was waiting for this patch. XML output caused Bug 8513 : With XML output, an empty tag will appear has : <a/>. With HTML output, it will appear has : <a></a>. For web browser the first form for an anchor is not allowed. In most case, HTML output is more friendly with XSLT result and causes less crash. I tested a bit in UNIMARC, all ok. Seems good for me too. Marked as Passed QA. Patch pushed to master Pushed to 3.8.x, will be in 3.8.5 Works on master. |