Bug 8513 - OPAC detail page broken with XSLT
Summary: OPAC detail page broken with XSLT
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low major (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 10:17 UTC by Fridolin Somers
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
OPAC detail page broken (127.31 KB, image/jpeg)
2012-07-27 10:17 UTC, Fridolin Somers
Details
Proposed patch (2.02 KB, patch)
2012-07-30 12:53 UTC, Fridolin Somers
Details | Diff | Splinter Review
Proposed patch (all MARC) (8.93 KB, patch)
2012-08-06 10:05 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 8513: OPAC detail page broken with XSLT (8.98 KB, patch)
2012-08-09 09:52 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-07-27 10:17:20 UTC
Created attachment 11158 [details]
OPAC detail page broken

When using OPACXSLTDetailsDisplay = default, the OPAC detail page includes the HTML code of a result page, see screen shot.
Very odd.
Comment 1 Fridolin Somers 2012-07-30 12:53:16 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-08-06 08:03:47 UTC
Fridolyn, does this only occur in UNIMARC, or does NORMARC and MARC21 have the same problem?
Comment 3 Fridolin Somers 2012-08-06 10:05:16 UTC Comment hidden (obsolete)
Comment 4 Fridolin Somers 2012-08-06 10:07:54 UTC
Note that there are a lot of links in intranet XSLT, the problem can appear there.

For me, the problem could be solved by changing XSTL output method.
I send a mail 'XSLT output method' to koha-devel to open the discussion.
Comment 5 Chris Cormack 2012-08-09 09:52:33 UTC
Created attachment 11478 [details] [review]
Bug 8513: OPAC detail page broken with XSLT

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 6 Mason James 2012-08-10 05:31:04 UTC
(In reply to comment #5)
> Created attachment 11478 [details] [review]
> Bug 8513: OPAC detail page broken with XSLT
> 
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

patch looks good and applies, passing QA

fyi: we need to add some xsl, xml and javascript tests to the Koha qa-tools... :)
Comment 7 Chris Cormack 2012-08-10 05:43:21 UTC
Check xt and xt/author tests for the xml and xslt already exist
Comment 8 Chris Cormack 2012-08-10 22:02:58 UTC
prove t/00-valid-xml.t                                              
t/00-valid-xml.t .. ok    
All tests successful.
Files=1, Tests=94,  5 wallclock secs ( 0.10 usr  0.01 sys +  0.47 cusr  0.68 csys =  1.26 CPU)
Result: PASS

Pushed to 3.8.x, will be in 3.8.4
Comment 9 Paul Poulain 2012-08-29 13:31:07 UTC
Patch pushed, but the same problem also exist in staff interface I think, I just checked intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl, and the same code is here.
Comment 10 Chris Cormack 2012-08-29 21:00:56 UTC
Paul is there a bug for the staff side?
Comment 11 Jared Camins-Esakov 2012-08-29 21:05:05 UTC
(In reply to comment #10)
> Paul is there a bug for the staff side?

This will be fixed by bug 8678.