Summary: | Software error on help of main page | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, nengard, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 8705: Software error on help of main page Proposed patch (revised) Proposed patch (revised 2) Bug 8705: Software error on help of main page |
Description
Fridolin Somers
2012-08-30 16:41:52 UTC
Created attachment 11898 [details] [review] Proposed patch Very small patch. When help page is not found from URL, display mainpage help. *** Bug 7623 has been marked as a duplicate of this bug. *** Created attachment 11899 [details] [review] [SIGNED-OFF] Bug 8705: Software error on help of main page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Hum... Ok it is a simple patch and currently, it works. But if someone adds a test before, this one will not save. I can't explain that... an example will be more meaningful: my $s = "aaa"; $s =~ m/a(.)a/; say $1; => display "a" But! my $s = "aaa"; $s =~ m/a(.)a/; say $1; $s =~ m/b(.)b/; say $1 => display "a" x 2 $1 is defined in the second case. We have to test with a if when we want used $1 I don't mark it as Failed QA because this patch does not introduce this, but a followup is highly welcomed :) Created attachment 11921 [details] [review] Proposed patch (revised) (In reply to comment #4) I understand, $1 should only be used if pattern matches. I revised patch to wrap help template from URL behavior into a sub. Sorry but critic FAIL Subroutine prototypes used at line 28, column 1. See page 194 of PBP. (Severity: 5) Created attachment 11924 [details] [review] Proposed patch (revised 2) Is this better ? Can you say more about it ? Created attachment 11944 [details] [review] Bug 8705: Software error on help of main page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It's ok for me. > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 6980862 Bug 8705: Software error on help of main page help.pl * help.pl OK Patch pushed to master Pushed to 3.8.x, will be in 3.8.5 |