| Summary: | tags always say approved | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Tools | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, paul.poulain, veron |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
rejected say approved
rejected and approved all say approved Bug 8707 - tags always say approved [SIGNED-OFF] Bug 8707 - tags always say approved |
||
Created attachment 11901 [details]
rejected and approved all say approved
See the buttons on the right show approved no matter what.
Comment on attachment 11901 [details]
rejected and approved all say approved
Workaround I:
Check checkboxes next tags you want to approve again and use the "Approve" button at the bottom of the table.
Workaround II:
On the line of a rejected tag, click the "Reject" button. Thsi will activate the "Approved" button.
Marc
...but with Workaround II the "Approved" button becomes active, but it does nothing... Marc ...and some more findings: The button I mentioned in Comment #3 only _seems_ to do nothing. As soon I reload the page or apply the filter again the status is changed. Created attachment 13118 [details] [review] Bug 8707 - tags always say approved Template scope error caused an incorrect state on the approval/rejection buttons when viewing rejected tags. To test, go to Tags and view the list of rejected tags. In the "Actions" column, the "rejected" button should be greyed out, and the "approve" button active. Created attachment 13144 [details] [review] [SIGNED-OFF] Bug 8707 - tags always say approved Template scope error caused an incorrect state on the approval/rejection buttons when viewing rejected tags. To test, go to Tags and view the list of rejected tags. In the "Actions" column, the "rejected" button should be greyed out, and the "approve" button active. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> If this can go in to 3.10 and 3.8 that would be awesome!! QA Comments: Easy fix, just one : I think this line could be removed in the review.pl file approved => 0, # dummy value (also EXPR) Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released with 3.10.0 |
Created attachment 11900 [details] rejected say approved This happens in master and 3.8.4 (those are the ones I tested). When you look at your tags there used to be tabs across the top for pending/approved/rejected - now there isn't, but this isn't as big a deal as the fact that tags that were rejected have the 'approved' box depressed. See attached images.