Summary: | Poorly ordered and triggers warning in marctagstructure.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | System Administration | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Changed and statement to have boundary check first.
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl |
Description
Mark Tompsett
2012-09-03 04:21:26 UTC
Created attachment 11942 [details] [review] Changed and statement to have boundary check first. This is one of those strange bugs where the line number for the error number is not where the error is. Fixing the condition in the while loop fixes the warning generated by the test plan already posted on this bug. Created attachment 11953 [details] [review] Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl An array boundary check was after a comparison using the array. By changing the logic which had " and ( $j < $cnt)" to be at the beginning "( $j < $cnt ) and ", the warning is no longer shown in the error log. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 146447b Bug 8714 - Poorly ordered and triggers warning in marctagstructur admin/marctagstructure.pl * admin/marctagstructure.pl OK Patch pushed to master Pushed to 3.8.x, will be in 3.8.5 |