Bug 8740

Summary: Serials Claims should be exportable all at once
Product: Koha Reporter: MJ Ray (software.coop) <mjr>
Component: SerialsAssignee: MJ Ray (software.coop) <mjr>
Status: Failed QA --- QA Contact:
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, colin.campbell, jonathan.druart, paul.poulain, veron
Version: Main   
Hardware: All   
OS: All   
URL: http://intranet/cgi-bin/koha/serials/claims.pl
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: enh bug 8740 Serials Claims should be exportable all at once
[SIGNED OFF]enh bug 8740 Serials Claims should be exportable all at once
enh bug 8740 Serials Claims should be exportable all at once
enh bug 8740 Serials Claims should be exportable all at once
enh bug 8740 Serials Claims should be exportable all at once

Description MJ Ray (software.coop) 2012-09-07 17:15:22 UTC
At the moment, you have to step through vendors one at a time. It should be possible to see all overdues at once, if chosen explicitly because the list may be large.
Comment 1 MJ Ray (software.coop) 2012-09-07 17:37:08 UTC Comment hidden (obsolete)
Comment 2 Joy Nelson 2012-09-11 20:43:18 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-09-12 13:57:49 UTC
QA comments:
This patch allows $supplierid to be a string or an integer.
We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==)

Maybe a better option would be to set the "all suppliers" value with -1.

Marked as Failed QA
Comment 4 MJ Ray (software.coop) 2013-03-01 00:33:44 UTC Comment hidden (obsolete)
Comment 5 MJ Ray (software.coop) 2013-03-01 00:35:49 UTC Comment hidden (obsolete)
Comment 6 MJ Ray (software.coop) 2013-03-01 00:39:54 UTC
I've rebased this and changed a == to an eq to avoid the warnings.

I have not set the "all suppliers" value with -1 because I dislike magic numbers and it is possible (but unlikely unless you mess with the database directly) to have a vendor with id -1 which would become unselectable alone.

I ask for reviews and maybe new signoffs, please.
Comment 7 Paul Poulain 2013-03-20 11:06:03 UTC
Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr>
Comment 8 Paul Poulain 2013-03-20 11:06:23 UTC
Created attachment 16491 [details] [review]
enh bug 8740 Serials Claims should be exportable all at once

Test plan:
1. Visit Serials: Claims and look at the vendor list drop-down
2. select All
3. click OK
4. export them all

Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Comment 9 Jonathan Druart 2013-05-27 12:58:15 UTC
QA comment:
Sorry MJ but the warning still occur when the string is not initialized:

  Use of uninitialized value $supplierid in string eq at /home/koha/src/serials/claims.pl line 71

Marked as Failed QA.
Comment 10 Marc VĂ©ron 2016-10-04 16:12:17 UTC
Still valid?