Bug 8740 - Serials Claims should be exportable all at once
Summary: Serials Claims should be exportable all at once
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: MJ Ray (software.coop)
QA Contact:
URL: http://intranet/cgi-bin/koha/serials/...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 17:15 UTC by MJ Ray (software.coop)
Modified: 2016-10-04 16:12 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
enh bug 8740 Serials Claims should be exportable all at once (2.28 KB, patch)
2012-09-07 17:37 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
[SIGNED OFF]enh bug 8740 Serials Claims should be exportable all at once (2.37 KB, patch)
2012-09-11 20:43 UTC, Joy Nelson
Details | Diff | Splinter Review
enh bug 8740 Serials Claims should be exportable all at once (2.46 KB, patch)
2013-03-01 00:33 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
enh bug 8740 Serials Claims should be exportable all at once (2.46 KB, patch)
2013-03-01 00:35 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
enh bug 8740 Serials Claims should be exportable all at once (2.52 KB, patch)
2013-03-20 11:06 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description MJ Ray (software.coop) 2012-09-07 17:15:22 UTC
At the moment, you have to step through vendors one at a time. It should be possible to see all overdues at once, if chosen explicitly because the list may be large.
Comment 1 MJ Ray (software.coop) 2012-09-07 17:37:08 UTC Comment hidden (obsolete)
Comment 2 Joy Nelson 2012-09-11 20:43:18 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-09-12 13:57:49 UTC
QA comments:
This patch allows $supplierid to be a string or an integer.
We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==)

Maybe a better option would be to set the "all suppliers" value with -1.

Marked as Failed QA
Comment 4 MJ Ray (software.coop) 2013-03-01 00:33:44 UTC Comment hidden (obsolete)
Comment 5 MJ Ray (software.coop) 2013-03-01 00:35:49 UTC Comment hidden (obsolete)
Comment 6 MJ Ray (software.coop) 2013-03-01 00:39:54 UTC
I've rebased this and changed a == to an eq to avoid the warnings.

I have not set the "all suppliers" value with -1 because I dislike magic numbers and it is possible (but unlikely unless you mess with the database directly) to have a vendor with id -1 which would become unselectable alone.

I ask for reviews and maybe new signoffs, please.
Comment 7 Paul Poulain 2013-03-20 11:06:03 UTC
Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr>
Comment 8 Paul Poulain 2013-03-20 11:06:23 UTC
Created attachment 16491 [details] [review]
enh bug 8740 Serials Claims should be exportable all at once

Test plan:
1. Visit Serials: Claims and look at the vendor list drop-down
2. select All
3. click OK
4. export them all

Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Comment 9 Jonathan Druart 2013-05-27 12:58:15 UTC
QA comment:
Sorry MJ but the warning still occur when the string is not initialized:

  Use of uninitialized value $supplierid in string eq at /home/koha/src/serials/claims.pl line 71

Marked as Failed QA.
Comment 10 Marc Véron 2016-10-04 16:12:17 UTC
Still valid?