Summary: | Log circulation renewal | ||
---|---|---|---|
Product: | Koha | Reporter: | Amit Gupta <kohapatch> |
Component: | Transaction logs | Assignee: | David Cook <dcook> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, jrobb, marjorie.barry-vila, martin.renvoize, nick, sally.healey, savitra.sirohi |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8752 - Log circulation renewal
[SIGNED-OFF] Bug 8752 - Log circulation renewal Bug 8752 - Log circulation renewal |
Description
Amit Gupta
2012-09-11 04:05:07 UTC
Created attachment 20453 [details] [review] Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". Created attachment 20580 [details] [review] [SIGNED-OFF] Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works as advertised, and I think it's an appropriate extension to the scope of IssueLog. Created attachment 20835 [details] [review] Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the "IssueLog" preference, but we could add a new syspref for "RenewLog". Personally, I figure it's just a "re-issue" so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the "Object". Signed-off-by: Owen Leonard <oleonard@myacpl.org> This works as advertised, and I think it's an appropriate extension to the scope of IssueLog. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I notice that if you renew by going to the patron's summary, then clicking the renew button, only the renewal gets logged -- as expected. However, if you renewal by going to the checkout page, then entering the barcode of the item to renew, the renewal gets logged twice: once as an ISSUE, and once as a RENEW. Would folks agree that it shouldn't be logged twice? I agree, logging it twice will not provide correct statistics. I think logging it as a renewal would be correct, after giving it some thought. What we do in UI is another checkout, but the loan period gets calculated as renewal and the renewal counter is increased - so it's a renwal, not a new check out. What do others think? Hi, Is this bug still under consideration for inclusion? We would really like to see a renewal log included in Koha, especially if it enabled us to see which user performed the renewal. (In reply to Katrin Fischer from comment #5) > I agree, logging it twice will not provide correct statistics. I think > logging it as a renewal would be correct, after giving it some thought. > What we do in UI is another checkout, but the loan period gets calculated as > renewal and the renewal counter is increased - so it's a renwal, not a new > check out. > What do others think? I think your right Katrin, what we do as a checkout in the UI is really a renewal and should be going through that code path and thus only logging the renewal. Moving to Failed QA for the double logging - can we fix this? |