Bug 8752 - Log circulation renewal
Summary: Log circulation renewal
Status: RESOLVED DUPLICATE of bug 17708
Alias: None
Product: Koha
Classification: Unclassified
Component: Transaction logs (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 04:05 UTC by Amit Gupta
Modified: 2017-08-10 14:55 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8752 - Log circulation renewal (1.78 KB, patch)
2013-08-19 02:46 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8752 - Log circulation renewal (1.96 KB, patch)
2013-08-23 13:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8752 - Log circulation renewal (1.98 KB, patch)
2013-09-06 17:23 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2012-09-11 04:05:07 UTC
Renewal log is not capturing in action_logs table after renewal the books.
Comment 1 David Cook 2013-08-19 02:46:00 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-08-23 13:21:33 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-09-06 17:23:43 UTC
Created attachment 20835 [details] [review]
Bug 8752 - Log circulation renewal

Currently, circulation renewals are not being logged.

This patch logs renewals under the Circulation module with an action
of RENEW.

At the moment, it relies on the "IssueLog" preference, but we could add
a new syspref for "RenewLog".

Personally, I figure it's just a "re-issue" so I don't know that we
need another preference, but system preferences are cheap, so if people
think a follow-up is necessary, I'm open to the idea.

Test Plan:

0) Turn on IssueLog and ReturnLog in the system preferences
1) Checkout an item
2) Note that there is a CIRCULATION ISSUE log entry
3) Renew that item
4) Note that there is NOT a log entry
5) Return that item
6) Note that there is a CIRCULATION RETURN log entry

7) Apply patch

8) Repeat Step #3 (i.e. renew that item).
9) Note that there is now a CIRCULATION RENEW log entry

N.B. Logs can be viewed by directly querying the database, viewing
the Modification Log for the patron attached to the checkout/renew/
return, or by viewing the logs in the Tools module  using the item's
itemnumber as the "Object".

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

This works as advertised, and I think it's an appropriate extension to
the scope of IssueLog.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-09-06 18:42:51 UTC
I notice that if you renew by going to the patron's summary, then clicking the renew button, only the renewal gets logged -- as expected.

However, if you renewal by going to the checkout page, then entering the barcode of the item to renew, the renewal gets logged twice: once as an ISSUE, and once as a RENEW.

Would folks agree that it shouldn't be logged twice?
Comment 5 Katrin Fischer 2013-09-08 08:46:31 UTC
I agree, logging it twice will not provide correct statistics. I think logging it as a renewal would be correct, after giving it some thought.
What we do in UI is another checkout, but the loan period gets calculated as renewal and the renewal counter is increased - so it's a renwal, not a new check out.
What do others think?
Comment 6 Sally 2016-10-18 13:58:10 UTC
Hi,

Is this bug still under consideration for inclusion?  

We would really like to see a renewal log included in Koha, especially if it enabled us to see which user performed the renewal.
Comment 7 Martin Renvoize 2016-10-19 08:32:56 UTC
(In reply to Katrin Fischer from comment #5)
> I agree, logging it twice will not provide correct statistics. I think
> logging it as a renewal would be correct, after giving it some thought.
> What we do in UI is another checkout, but the loan period gets calculated as
> renewal and the renewal counter is increased - so it's a renwal, not a new
> check out.
> What do others think?

I think your right Katrin, what we do as a checkout in the UI is really a renewal and should be going through that code path and thus only logging the renewal.
Comment 8 Katrin Fischer 2016-10-19 17:22:59 UTC
Moving to Failed QA for the double logging - can we fix this?
Comment 9 Nick Clemens 2017-08-10 14:55:52 UTC

*** This bug has been marked as a duplicate of bug 17708 ***