Summary: | can't run report after saving | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, mtj, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7993 | ||
Bug Blocks: | |||
Attachments: |
run report after saving
run report in 3.8.4 Bug 8811 - can't run report after saving [SIGNED-OFF] Bug 8811 - can't run report after saving |
Created attachment 12474 [details]
run report in 3.8.4
The link was there in 3.8.4
From IRC: [10:29] <oleonard> nengard: The link doesn't appear because [% id %] is not present in the template, and the button doesn't work because [% id %] isn't present in the template [10:30] <oleonard> the edit button won't work either for the same reason Created attachment 12475 [details] [review] Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. Created attachment 12476 [details] [review] [SIGNED-OFF] Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested creating reports and was able to run them after saving. (In reply to comment #4) > Created attachment 12476 [details] [review] > [SIGNED-OFF] Bug 8811 - can't run report after saving > > Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> > Tested creating reports and was able to run them after saving. works well, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * d42ef70 Bug 8811 - can't run report after saving reports/guided_reports.pl * reports/guided_reports.pl OK Patch pushed to master. This patch is a bugfix for an ENH in 3.10, so not relevant for 3.8 Released in 3.10.0 |
Created attachment 12472 [details] run report after saving After saving a new report, the link to run this report is gone, but the button remains (which is good), however if you click the button to run report it brings you to a blank screen that just has the 'New' button on it.