| Summary: | clicking basketgroup name in closed basketgroups reopens it | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Acquisitions | Assignee: | Mathieu Saby <mathsabypro> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, mathsabypro |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/acqui/basketgroup.pl?booksellerid=1#closed | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
[PATCH] Bug 8853: Suppress links in basketgroups list
[SIGNED-OFF] Bug 8853: Suppress links in basketgroups list Bug 8853: Suppress links in basketgroups list |
||
|
Description
Nicole C. Engard
2012-10-01 14:09:58 UTC
Hello Nicole In your title you speak of "closed baskets", but I think you mean "closed basket groups"? If you mean basket groups, we have seen the same behavior, and it is clearly a UX problem. Clicking on closed basketgroups should show some summary, or it should be impossible, but it should NOT reopen basketgroup! For the moment I can make a very small patch : deleting the link. And if somebody wants to create a summary page, it will be an ENH Do you agree with that? M. Saby Rennes 2 University Yes you are right. OK Nicole, I changed the name of the bug, and I will make a patch. M. Saby I will take profit of the occasion to add more information on basketgroup list page, so it won't be necessary to click on each basketgroup to know some basical details (billingplace, deliveryplace, number of baskets in each basketgroup, number of orders, number of received orders...) In basketgroups, actions are triggered by buttons. In other pages (as booksellers), they are triggered by links. It sound strange for me. Is there a rule for that in Koha? M. Saby Created attachment 15998 [details] [review] [PATCH] Bug 8853: Suppress links in basketgroups list Here is a small patch, just to suppress links around basketgroup name. I am working on an other patch for improving basketgroup management. M. Saby Created attachment 16038 [details] [review] [SIGNED-OFF] Bug 8853: Suppress links in basketgroups list In the table listing all closed basketgroups, clicking the name of a basketgroup reopen it. To edit an open basketgroup or reopen a closed basketgroup, there are specific buttons in "Action" column. So the link around basketgroup name is an UX problem. This patch suppress the link around basketgroup name, in both "closed" and "open" tab. To test : 1. create some closed and open basketgroups 2. check links are not showing anymore Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: This patch fixes an ergonomic issue (action edit or reopen on clicking a basketgroup name link). qa tools complains on tabulation characters but the file contains too much tab. Marked as Passed QA. Created attachment 16040 [details] [review] Bug 8853: Suppress links in basketgroups list In the table listing all closed basketgroups, clicking the name of a basketgroup reopen it. To edit an open basketgroup or reopen a closed basketgroup, there are specific buttons in "Action" column. So the link around basketgroup name is an UX problem. This patch suppress the link around basketgroup name, in both "closed" and "open" tab. To test : 1. create some closed and open basketgroups 2. check links are not showing anymore Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.4 |