Summary: | docs/history.txt file missing for about.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, m.de.rooy, robin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10915 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 8911 - history.txt file missing for about.pl
Bug 8911 - history.txt file missing for about.pl [PASSED QA] Bug 8911 - history.txt file missing for about.pl |
Description
Mark Tompsett
2012-10-12 07:05:33 UTC
Assigned to Robin, as per his instructions. So, this appears to be a larger issue: if I do a makefile install, history.txt isn't installed anywhere. Created attachment 19354 [details] [review] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Created attachment 19452 [details] [review] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Robin, could you take a look at this please? :) Created attachment 19827 [details] [review] [PASSED QA] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Tomás! This patch has been pushed to 3.12.x, will be in 3.12.2. Added a followup that advertises the change for people updating to add the line to koha-conf.xml manually. Pushed to 3.10.x, will be in 3.10.10 When just upgrading your dev install, you now lose the contents of the timeline page on about. With warnings like: about.pl: Use of uninitialized value $docdir in string at /usr/share/koha/testclone/about.pl line 152. about.pl: readline() on closed filehandle $file at /usr/share/koha/testclone/about.pl line 158. Please see bug 10915 |