Summary: | koha-common*.deb should depend on cron | ||
---|---|---|---|
Product: | Koha | Reporter: | johannes_graumann |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | basilanice, fridolin.somers, gmcharlt, mtompset, robin, tomascohen |
Version: | Main | ||
Hardware: | PC | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 8921: koha-common*.deb should depend on cron
Bug 8921: koha-common*.deb should depend on cron Bug 8921: koha-common*.deb should depend on cron [PASSED QA] Bug 8921: koha-common*.deb should depend on cron |
Description
johannes_graumann
2012-10-15 14:31:49 UTC
"In Debian the cron package is installed as part of the base system, and will be running by default." (http://www.debian-administration.org/articles/56) I also looked at Ubuntu. (https://help.ubuntu.com/community/CronHowto) is written such that one can assume it is installed as well. What virtual environment are you talking about? Can you cite an example? I know this would be a problem from RPM-based Linux variants, but then you wouldn't be installing from packages. There's no harm on depending on it, but it shouldn't really be necessary. I had the experience of cron being missed despite it not being listed as a prerequisite in an lxc container (minimal system setup via debbootstrap). Joh You may note that the prior comment doesn't really mak sense ... new attempt: in an debbootstrapped lxc container's minimal system cron is not necessarily present. Zebra's cron job functionality may thus break despite cron not being listed as a prerequisite. Joh Yeah, it's an easy fix and I shouldn't imagine there are side-effects from it. Probably should also include 'at' in the list if it's not there already. Johannes, if you want you could make a patch for it easily enough. Just edit debian/control.in and stick cron and at into the one or two places they need to go. Created attachment 23307 [details] [review] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ What if some administrator chose some other cron other than cron? For example, anacron? (In reply to M. Tompsett from comment #7) > What if some administrator chose some other cron other than cron? For > example, anacron? Anacron is a different thing that relies on cron to work. However, this is a fair point. We should depend on cron-daemon, which is a virtual package. 'cron' is the only thing that provides this, but in the future, this may change. $ apt-cache showpkg cron-daemon Package: cron-daemon Versions: Reverse Depends: request-tracker4,cron-daemon lyskom-server,cron-daemon logrotate,cron-daemon Dependencies: Provides: Reverse Provides: cron 3.0pl1-124ubuntu2 Created attachment 23315 [details] [review] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Created attachment 23851 [details] [review] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23859 [details] [review] [PASSED QA] Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No entry in debian/control yet, but according to comments in the file this file is generated from control.in - so this should be ok. Pushed to master. Thanks, Tomás! Patch pushed to 3.14.x, will be in 3.14.3. |