Bug 8921 - koha-common*.deb should depend on cron
Summary: koha-common*.deb should depend on cron
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: PC Linux
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 14:31 UTC by johannes_graumann
Modified: 2017-01-16 05:05 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8921: koha-common*.deb should depend on cron (963 bytes, patch)
2013-12-04 17:36 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 8921: koha-common*.deb should depend on cron (984 bytes, patch)
2013-12-05 00:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 8921: koha-common*.deb should depend on cron (1.02 KB, patch)
2013-12-29 07:50 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 8921: koha-common*.deb should depend on cron (1.21 KB, patch)
2013-12-29 09:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description johannes_graumann 2012-10-15 14:31:49 UTC
koha-common installation does currently not automatically pull in cron, which makes the indexing cron-job (zebra) not functional.

Virtualized environments do not necessarily provide cron out of the box, so the dependency is particularly necessary there.
Comment 1 Mark Tompsett 2013-10-09 04:22:11 UTC
"In Debian the cron package is installed as part of the base system, and will be running by default." (http://www.debian-administration.org/articles/56)

I also looked at Ubuntu. (https://help.ubuntu.com/community/CronHowto) is written such that one can assume it is installed as well.

What virtual environment are you talking about? Can you cite an example? I know this would be a problem from RPM-based Linux variants, but then you wouldn't be installing from packages.
Comment 2 Robin Sheat 2013-10-09 04:26:49 UTC
There's no harm on depending on it, but it shouldn't really be necessary.
Comment 3 johannes_graumann 2013-10-09 07:51:34 UTC
I had the experience of cron being missed despite it not being listed as a prerequisite in an lxc container (minimal system setup via debbootstrap).

Joh
Comment 4 johannes_graumann 2013-10-09 08:30:19 UTC
You may note that the prior comment doesn't really mak sense ... new attempt:
in an debbootstrapped lxc container's minimal system cron is not necessarily present. Zebra's cron job functionality may thus break despite cron not being listed as a prerequisite.

Joh
Comment 5 Robin Sheat 2013-10-09 08:49:13 UTC
Yeah, it's an easy fix and I shouldn't imagine there are side-effects from it. Probably should also include 'at' in the list if it's not there already.

Johannes, if you want you could make a patch for it easily enough. Just edit debian/control.in and stick cron and at into the one or two places they need to go.
Comment 6 Tomás Cohen Arazi 2013-12-04 17:36:37 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2013-12-04 23:59:59 UTC
What if some administrator chose some other cron other than cron? For example, anacron?
Comment 8 Robin Sheat 2013-12-05 00:07:08 UTC
(In reply to M. Tompsett from comment #7)
> What if some administrator chose some other cron other than cron? For
> example, anacron?

Anacron is a different thing that relies on cron to work.

However, this is a fair point. We should depend on cron-daemon, which is a virtual package. 'cron' is the only thing that provides this, but in the future, this may change.

$ apt-cache showpkg cron-daemon
Package: cron-daemon
Versions: 

Reverse Depends: 
  request-tracker4,cron-daemon
  lyskom-server,cron-daemon
  logrotate,cron-daemon
Dependencies: 
Provides: 
Reverse Provides: 
cron 3.0pl1-124ubuntu2
Comment 9 Tomás Cohen Arazi 2013-12-05 00:39:22 UTC Comment hidden (obsolete)
Comment 10 Chris Cormack 2013-12-29 07:50:17 UTC Comment hidden (obsolete)
Comment 11 Katrin Fischer 2013-12-29 09:09:44 UTC
Created attachment 23859 [details] [review]
[PASSED QA] Bug 8921: koha-common*.deb should depend on cron

Trivial patch to add 'cron-daemon' as dependency for the koha-common
package. 'cron' is usually pulled in any minimal Ubuntu/Debian
install, but in some circumstances (using debootstrap) it might be
absent.
As Robin said, this doesn't seem to have any side effects.

Regards
To+

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
No entry in debian/control yet, but
according to comments in the file this file is generated
from control.in - so this should be ok.
Comment 12 Galen Charlton 2013-12-30 15:06:29 UTC
Pushed to master.  Thanks, Tomás!
Comment 13 Fridolin Somers 2014-01-27 13:06:55 UTC
Patch pushed to 3.14.x, will be in 3.14.3.