| Summary: | submit buttons have blue background | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, jcamins, jonathan.druart, melia, mtj, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
one example
Bug 8931 - submit buttons have blue background [SIGNED-OFF] Bug 8931 - submit buttons have blue background example of the opposite Bug 8931 [Follow-up] submit buttons have blue background [Signed off] Bug 8931 [Follow-up] submit buttons have blue background |
||
Happens on Chrome on Mac as well. Nicole Created attachment 12863 [details] [review] Bug 8931 - submit buttons have blue background This patch specifies a transparent background for fieldsets and divs with the class "action," which are typically containers for the submit/cancel actions. For testers, a good example page to view is the "set library" page. Created attachment 12864 [details] [review] [SIGNED-OFF] Bug 8931 - submit buttons have blue background This patch specifies a transparent background for fieldsets and divs with the class "action," which are typically containers for the submit/cancel actions. For testers, a good example page to view is the "set library" page. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 12957 [details]
example of the opposite
This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have a blue background - or be below the blue box ...
(In reply to comment #4) > Created attachment 12957 [details] > example of the opposite > > This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have > a blue background - or be below the blue box ... Nicole, what do you want to mean with this attachment ? Does it mean I should not push this patch (I see no difference between before and after this patch for the background-color, that is white in both cases) Pushing the patch is A-OK. I'm just showing Owen one other example that similar that this patch doesn't fix. Nicole (In reply to comment #5) > (In reply to comment #4) > > Created attachment 12957 [details] > > example of the opposite > > > > This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have > > a blue background - or be below the blue box ... > > Nicole, what do you want to mean with this attachment ? Does it mean I > should not push this patch (I see no difference between before and after > this patch for the background-color, that is white in both cases) i have confirmed a difference before and after this patch passing QA, patch works as stated :) This patch has been pushed to master and is suitable for backporting to 3.10. Patch pushed to branch 3.10.x Created attachment 13311 [details] [review] Bug 8931 [Follow-up] submit buttons have blue background This follow-up removes the white background from fieldsets with class "action" when they are embedded inside another fieldset (Comment 4). Created attachment 13324 [details] [review] [Signed off] Bug 8931 [Follow-up] submit buttons have blue background This follow-up removes the white background from fieldsets with class "action" when they are embedded inside another fieldset (Comment 4). Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> I tested on the "files" tab of the patron record, and I see that the white part behind the upload button is now gone. Simple css fix. Marked as Passed QA. This patch has been pushed to master. follow-up pushed to branch 3.10.x Released in 3.10.0 |
Created attachment 12862 [details] one example In my staff client on Mac/FF all submit buttons have a blue shaded background - I think it should be white or be included in the outline for the box.