Bug 8931 - submit buttons have blue background
Summary: submit buttons have blue background
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 17:29 UTC by Nicole C. Engard
Modified: 2013-12-05 20:05 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
one example (29.18 KB, image/png)
2012-10-16 17:29 UTC, Nicole C. Engard
Details
Bug 8931 - submit buttons have blue background (1.01 KB, patch)
2012-10-16 18:16 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8931 - submit buttons have blue background (1.06 KB, patch)
2012-10-16 18:50 UTC, Nicole C. Engard
Details | Diff | Splinter Review
example of the opposite (17.14 KB, image/png)
2012-10-19 15:34 UTC, Nicole C. Engard
Details
Bug 8931 [Follow-up] submit buttons have blue background (1022 bytes, patch)
2012-11-08 16:45 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed off] Bug 8931 [Follow-up] submit buttons have blue background (1.03 KB, patch)
2012-11-08 20:43 UTC, Melia Meggs
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-10-16 17:29:12 UTC
Created attachment 12862 [details]
one example

In my staff client on Mac/FF all submit buttons have a blue shaded background - I think it should be white or be included in the outline for the box.
Comment 1 Nicole C. Engard 2012-10-16 17:30:13 UTC
Happens on Chrome on Mac as well.

Nicole
Comment 2 Owen Leonard 2012-10-16 18:16:00 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2012-10-16 18:50:26 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2012-10-19 15:34:54 UTC
Created attachment 12957 [details]
example of the opposite

This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have a blue background - or be below the blue box ...
Comment 5 Paul Poulain 2012-10-28 18:52:40 UTC
(In reply to comment #4)
> Created attachment 12957 [details]
> example of the opposite
> 
> This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have
> a blue background - or be below the blue box ...

Nicole, what do you want to mean with this attachment ? Does it mean I should not push this patch (I see no difference between before and after this patch for the background-color, that is white in both cases)
Comment 6 Nicole C. Engard 2012-10-28 19:04:25 UTC
Pushing the patch is A-OK. I'm just showing Owen one other example that similar that this patch doesn't fix.

Nicole
Comment 7 Mason James 2012-11-01 11:21:24 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 12957 [details]
> > example of the opposite
> > 
> > This button on /cgi-bin/koha/members/files.pl?borrowernumber=53 should have
> > a blue background - or be below the blue box ...
> 
> Nicole, what do you want to mean with this attachment ? Does it mean I
> should not push this patch (I see no difference between before and after
> this patch for the background-color, that is white in both cases)

i have confirmed a difference before and after this patch


passing QA, patch works as stated :)
Comment 8 Jared Camins-Esakov 2012-11-01 14:36:14 UTC
This patch has been pushed to master and is suitable for backporting to 3.10.
Comment 9 Paul Poulain 2012-11-01 21:36:58 UTC
Patch pushed to branch 3.10.x
Comment 10 Owen Leonard 2012-11-08 16:45:57 UTC Comment hidden (obsolete)
Comment 11 Melia Meggs 2012-11-08 20:43:35 UTC
Created attachment 13324 [details] [review]
[Signed off] Bug 8931 [Follow-up] submit buttons have blue background

This follow-up removes the white background from fieldsets
with class "action" when they are embedded inside another
fieldset (Comment 4).

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Comment 12 Melia Meggs 2012-11-08 20:44:46 UTC
I tested on the "files" tab of the patron record, and I see that the white part behind the upload button is now gone.
Comment 13 Jonathan Druart 2012-11-09 13:09:50 UTC
Simple css fix.
Marked as Passed QA.
Comment 14 Jared Camins-Esakov 2012-11-10 01:09:16 UTC
This patch has been pushed to master.
Comment 15 Paul Poulain 2012-11-12 13:33:11 UTC
follow-up pushed to branch 3.10.x
Comment 16 Chris Cormack 2013-04-22 08:43:17 UTC
Released in 3.10.0