Summary: | Search RSS feeds does not show there items when subscribing in Firefox | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, kyle, liz, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
Bug 8935 - transport cost matrix could be prettier Bug 8936: Search RSS feeds does not show there items when subscribing in Firefox |
Description
Fridolin Somers
2012-10-17 08:51:53 UTC
Created attachment 12880 [details] [review] Proposed patch It appears a paragraph tag <p> is broken when RequestOnOpac is on. Created attachment 12886 [details] [review] Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) Sorry for the incorrect attachment, git bz typo! This isn't working for me, I think. In English before and after applying the patch, I get something like this. **** EXAMPLE **** Search for 'kw,wrdl: learn' Search results for 'kw,wrdl: learn' at Learning Ruby /By Fitzgerald, Michael,. Sebastopol, Calif. : O'Reilly, 2007 . xv, 238 p. : , "The language that powers Rails."--Cover. 24 cm.. 9780596529864 (pbk.) | 0596529864 (pbk.) Place Hold on Learning Ruby /Learning Perl /By Schwartz, Randal L.. Beijing ; | Sebastopol : O'Reilly, 2011 . xxi, 363 p. : , Includes index. 24 cm.. 9781449303587 Place Hold on Learning Perl / ***** /EXAMPLE **** Before and after the patch when switched to French, I get this: ***** EXAMPLE ***** Search for 'kw,wrdl: learn' Search results for 'kw,wrdl: learn' at Learning Ruby / Learning Perl / ***** /EXAMPLE ***** The results are a be mangled from copying and pasting, but basically, I'm not seeing any changes. If I am testing incorrectly, please let me know and post a test plan! test plan : ----------- The problem is more important in translated OPAC. But still, in 'en' you can still reproduce the bug : - Set RequestOnOpac syspref to "don't allow" - Perform a search on OPAC - Click on RSS feed button (next to result count) You get a view of RSS feeds. - Look at page source code : Ctrl+U You can see that in each <description> tag, there is a opening <p> tag with no closing </p> tag : example : <description><![CDATA[ <img src="http://images.amazon.com/images/P/2744102202.01.TZZZZZZZ.jpg" alt="" /> <p>By Maurizio FORTE. France loisirs 1996 . 295 p. , Cet ouvrage nous présente une nouvelle vision de l'intervention virtuelle,ici c'est un hymne à la gloire archéologique. 30 cm. 2744102202 </p><p> ]]></description> I hope it helps reproduce. Fridolyn, it seems you provided the patch and switched to signed-off yourself. Am I missing something ? Kyle, could you test & reproduce ? (In reply to comment #6) > Fridolyn, it seems you provided the patch and switched to signed-off > yourself. Am I missing something ? Kyle, could you test & reproduce ? Your right, patch needs sign-off Created attachment 13103 [details] [review] Bug 8936: Search RSS feeds does not show there items when subscribing in Firefox Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment : * small patch that fixes html error when requetOnOpac is off * passes koha-qa.pl passed QA Patch pushed to master Pushed to 3.8.x, will be in 3.8.7 Pushed to 3.6.x will be in 3.6.11. |