Summary: | search results should say on order in staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jcamins, jonathan.druart, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 10741 | ||
Attachments: |
results
Bug 8975 - search results should say on order in staff client [SIGNED-OFF] Bug 8975 - search results should say on order in staff client |
This is in 3.8.x and master. Created attachment 13235 [details] [review] Bug 8975 - search results should say on order in staff client In order to allow holds on items with notforloan = -1, processing of "unavailable" items in Search.pm was altered to exclude items with notforloan < 0. (See Bug 2341: items marked 'on order' not reserveable from search results). Doing so meant that such items were excluded from the list, in staff client search results, of items which are unavailable. This patch changes the logic of that processing so that items with notforloan < 0 are considered unavailable, but can still be placed on hold. To test, edit a record with a single item and view that record in search results. When the item is is on order (notforloan -1) it should say so. The holds link should be INactive only if: - item is withdrawn AND/OR - item is lost AND/OR - item is damaged (and AllowHoldsOnDamagedItems is off) AND/OR - item is not for loan, with notforloan > 0 I set AllowHoldsOnDamagedItems to don't allow and my bib with its only item marked damaged still shows the hold link - but if i click the hold link it says hold not normally allowed. My one with a lost status does say 'no holds allowed' in the search results and the ordered items are not listed appropriately. Nicole Created attachment 13237 [details] [review] [SIGNED-OFF] Bug 8975 - search results should say on order in staff client In order to allow holds on items with notforloan = -1, processing of "unavailable" items in Search.pm was altered to exclude items with notforloan < 0. (See Bug 2341: items marked 'on order' not reserveable from search results). Doing so meant that such items were excluded from the list, in staff client search results, of items which are unavailable. This patch changes the logic of that processing so that items with notforloan < 0 are considered unavailable, but can still be placed on hold. To test, edit a record with a single item and view that record in search results. When the item is is on order (notforloan -1) it should say so. The holds link should be INactive only if: - item is withdrawn AND/OR - item is lost AND/OR - item is damaged (and AllowHoldsOnDamagedItems is off) AND/OR - item is not for loan, with notforloan > 0 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass (note that a reindex is required if changing item statuses - which is why my first tests failed). [14:30] <nengard> oleonard, one problem [14:31] <nengard> a damaged item can't be put on hold - but it can be checked out - at least there is no rule against it - but because of the preference to not allow holds it says that damaged items are unavailable [14:32] <oleonard> nengard: That makes sense, but it's outside the scope of the bug I think The logic looks good to me. Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |
Created attachment 13084 [details] results When you have results in the staff client it has many statuses that show but not 'on order' - those items say available which is misleading. See attached. Two of the available items are actually on order and have not for loan - on order statuses.