Bug 2341 - items marked 'On Order' (notforloan == -1) don't interact correctly with opac-reserve.tmpl
Summary: items marked 'On Order' (notforloan == -1) don't interact correctly with opac...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: rel_3_2
Hardware: PC All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-10 02:03 UTC by Chris Cormack
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:50:04 UTC


---- Reported by jmf@liblime.com 2008-07-10 14:03:22 ----

The <!-- TMPL_IF NAME="forloan" --> test in opac-reserve.pl is failing for items marked 'On Order' (notforloan == -1)  and so there is no option to do a bib-level hold on them. Additionally, since the item is not a 'real' item, you shouldn't be able to place an item-level hold on it in the first place, otherwise, when real items are received, all holds will need to be manually transfered from the on order item to the received items. The only hold that should be allowed for a record with only one on-order item is a bib-level hold.

A related problem: Holds can't be placed on titles without any items. So ordering a new title doesn't allow patrons to place holds on that title (ordering doesn't create the 'fake' item), this means that the catalogers/acquisitions folks need to manually create an 'on order' item for that title. If there was a way to flag a title as 'on order', and allow 'on order' titles to have holds placed on them, perhaps the first half of this bug would be moot.



---- Additional Comments From gmcharlt@gmail.com 2008-08-14 09:50:17 ----

Submitted patch to allow OPAC title-level hold requests to be placed when all of the bib's items are on-order.

This bug should remain open: the issue of how and when to permit title-level requests on bibs with no items or bibs all of whose items are not individually requestable is not addressed by the patch.



---- Additional Comments From nengard@gmail.com 2008-08-19 12:05:51 ----

This is still not fixed.  With AllowOnShelfHolds set to off you cannot select a radio button or place a hold on an ordered item.  With AllowOnShelfHolds set to ON you can pick a radio button, but placing the 'Place Hold' button doesn't do anything.


PER CHAT:

[14:48]  <nengard> gmcharlt - i'm not sure this one works - or i'm not testing it right: http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=1999d41392615c5ed9afb3ff708753f6cfb45851 
[14:48]  <nengard> i can't place a hold on this one: http://opac-nce.dev.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=728 
[14:52]  <gmcharlt> nengard: know it sounds funny, but please turn on ALlowOnShelfHolds and let me know if form lets you place hold
[14:53]  <gmcharlt> would still be a bug, just a different one
[14:53]  <nengard> ahh - okay - ignore my email
[14:53]  <nengard> i sent it via emial cause i thought you were away
[14:53]  <nengard> going to test now
[14:54]  <nengard> gmcharlt - i can choose the radio button  - but it still doesn't put a hold on it
[14:55]  <gmcharlt> ok, please add info in http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2341 and I'll look at it later



---- Additional Comments From chris@bigballofwax.co.nz 2009-09-01 03:20:59 ----

Working on this now, specifically allowing holds on items that are on order, ie when a biblio has no items, but has an order open for one.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:50 UTC  ---

This bug was previously known as _bug_ 2341 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2341

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jmf@liblime.com.
CC member adrea@moablibrary.org does not have an account here
CC member bchurch@ptfs.com does not have an account here

Comment 1 Nicole C. Engard 2011-01-12 17:13:36 UTC
Is this still an issue? Did anyone look into it? I'm thinking I'm seeing this problem but need to do further testing to confirm that it's still an issue.
Comment 2 Chris Cormack 2011-02-02 20:24:10 UTC
I see a signed off patch for this so have updated status, please remember to do so
Comment 3 Chris Cormack 2011-02-03 09:04:02 UTC
Patch pushed, please test
Comment 4 MJ Ray (software.coop) 2011-02-06 11:14:14 UTC
This bug is mentioned in:
Bug 2341: items marked 'on	order' not reserveable from search results http://lists.koha-community.org/pipermail/koha-patches/2011-January/013733.html
Comment 5 Ian Walls 2011-02-08 03:31:56 UTC
Patch tested and confirmed.  Closing ticket.