Summary: | Remove Nonpublic General Note from OPAC authorities display | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | OPAC | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jcamins, liz, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Remove Nonpublic General Note from OPAC authorities display
Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Bug 8981 follow-up: case |
Description
David Cook
2012-10-29 22:03:11 UTC
Created attachment 13105 [details] [review] Remove Nonpublic General Note from OPAC authorities display To test: 1) Find authority records in your database that have a 667 field by using the following SQL: SELECT authid,ExtractValue(marcxml,'//datafield[@tag="667"]/*') AS info FROM auth_header HAVING info <> ''; 2) Go to the page using the following query string: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=<<authid from above>> 3) Note that the nonpublic general note appears on the screen 4) Apply patch 5) Reload page, and notice the 667 disappear without affecting any of the other fields Created attachment 13239 [details] [review] Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, with no side effects Created attachment 13776 [details] [review] Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, with no side effects Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Created attachment 13777 [details] [review] Bug 8981 follow-up: case While QAing your patch, I saw you were writting "MarcFlavour", it should have been "marcflavour" Will work with the UC, but let's be consistent. This patch fixes another MarcFlavour just a few lines before I spotted by chance QA comment: * passes koha-qa.pl * won't say anything about the feature itself because i'm not a MARC21 specialist, but do what it announce * you wrote "MarcFlavour" instead of "marcflavour" for the system preference, it works, but it's better to use the syspref form, so I've uploaded a follow-up that just fixes the wording. passed QA This patch has been pushed to master. Pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8 Does not apply on 3.6.x, please submit a 3.6 patch if necessary. Thanks! Liz |