Summary: | Allow bulkmarcimport to specify a framework code when importing MARC | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Command-line Utilities | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | katrin.fischer, melia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 9012 - --framework option for bulkmarcimport
[SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport [SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport |
Description
Robin Sheat
2012-11-06 04:47:36 UTC
Created attachment 13275 [details] [review] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported. Created attachment 13351 [details] [review] [SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Perlcritic failing before and after applying the patch, noting results here: "require" statement with library name as string at line 11, column 12. Use a bareword instead. (Severity: 5) Bareword file handle opened at line 74, column 3. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 74, column 3. See page 207 of PBP. (Severity: 5) Variable declared in conditional statement at line 439, column 9. Declare variables outside of the condition. (Severity: 5) But patch works nicely, passing QA. Created attachment 13824 [details] [review] [SIGNED-OFF] Bug 9012 - --framework option for bulkmarcimport This allows the --framework option to be specified when running bulkmarkimport. This option allows a framework code to be specified for the records being imported. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, perlcritic fails before and after. Tested - imported records with -framework FA, FA framework is used - imported records without -framework, default framework is used This patch has been pushed to master. |